fix: Remove debug AndroidManifest in release #1230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In 4d20202 for Flipper configuration, I created a release folder and : - I added an empty ReactNativeFlipper.java file to disable Flipper in release mode - I copy pasted the AndroidManifest.xml file from the debug folder which was not necessary. On the contrary, it is adding in release mode a useless android.permission.SYSTEM_ALERT_WINDOW permission So let's remove this AndroidManifest.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In 4d20202 for Flipper configuration, I created a release folder and :
So let's remove this AndroidManifest.
Checklist
Before merging this PR, the following things must have been done if relevant: