Update io.cozy.identities.md #190
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
update metadata
Crash--
reviewed
Feb 23, 2022
| @@ -21,14 +21,14 @@ unique by identifier **and** cozyMetadata.createdByApp | |||
| "_id": "62e5d66d6e11d19992b7efce794263f0", | |||
| "identifier": "[email protected]", | |||
| "contact": { | |||
| "address": [ | |||
| "addresses": [ | |||
There was a problem hiding this comment.
I'm not in favor of changing those keys. contact entry here, is the same as our io.cozy.contacts doctype. And in this doctype, we use the singular https://github.com/cozy/cozy-doctypes/blob/master/docs/io.cozy.contacts.md
Can we revert those changes? 🙏 .
Crash--
reviewed
Feb 23, 2022
| "1AJ": "12345.67", | ||
| "1BJ": "23456.78", | ||
| "currency": "EUR", | ||
| "file": "avis_impot_2022.pdf" |
There was a problem hiding this comment.
Not sure that the filename is useful since it can be renamed for instance. Can't we use a relationship here?
"tax_informations": [
{
"year": "2022",
"RFR": "56789.10",
"1AJ": "12345.67",
"1BJ": "23456.78",
"currency": "EUR",
"relationship": {
"type": "io.cozy.files",
"_id": XXX
}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Readme updated with new scrapped data from connectors