V7 stable #772
Draft
V7 stable #772
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order to be in line with the cozy ecosystem, node CI was upgraded. It created some issues that were fixed by upgrading cozy-client and mocking fetch in one of the tests
This is needed to use cozy-intent hooks and consume webview API
device-helper is a peerDep of cozy-intent, and cozy-bar is a different context than the consuming app, so it makes sense to add it as a prod dependency
Exposing api to parent app feat: Implement styling logic feat: Implement webview click handler Get context from state, hopefully injected via the exposed API by the WebviewIntentProvider of the parent app feat: Improve code readability feat: Use new backToHome method feat: Improve testing after review fix: Move webview reducer out of serializable data Otherwise we can get very breaking bugs if redux-persist tries to serialize the webviewService (which is impossible). Using Redux to store the webviewService is NOT a good idea anyway. Something better should be done, like using a WebviewIntentProvider feat: Display Flagship button in LeftBar test: Update test to latest implementation
feat: Implement Webview navigation
The old minilog github link seems to break the CI build
…ilog fix: Replace minilog with @cozy/minilog
It broke some apps because of outdated minilog
This version of cozy-ui can not work due to hook conflict
Button is causing trouble on Safari since it displays a button... Let's use an A like we do in all other places.
Adds convenience for debugging purposes
In case of race condition, error handling is done by native javascript (can't call() from undefined)
48x48 container, 32x32 img, marginLeft 4px Aligned center on X and Y axis
Will make developing features easier
If searchbar ever renders in FlagshipApp, this will currently trigger a breaking bug with iframes CSP issues. As of now we just ask the cozybar to not render the searchbar when we're in flagship so the issue does not exist
This handled cozy notes open when Drive needs to provide URL
it removes warnings in Drive cause by Searchbar
you have to use client coming from prop because with hoc or hooks it might cause this Minified React Error
An extra spacing came only on Safari browser removing display block prevents the extra margin
Since we send a (fake) message via postMessage, Cozy Drive's intent will catch it and send the _all_docs request. Like that we warm up the query and the data and we expect to give a better UX like that.
To fit with the structure of the new settings app.
Adapted the height to match the change in the support form which increased with the consent checkbox
Modal support was no longer useful as we direct to the contact settings page
Currently, cloud icon and back to dashboard (previously back to home) link go to context default redirection. We do not want this behavior because in this case, it can be impossible $to go to "home" which is our only "navigation" app.
Added several attributes to improve the general accessibility of the bar
- Update `cozy-client` from `27.14.1` to `38.2.1` - Update `cozy-device-helper` from `1.16.1` to `2.7.0` - Update `cozy-flags` from `2.8.5` to `3.0.1` - Update `cozy-interapp` from `0.4.9` to `0.8.0` - Update `cozy-realtime` from `4.0.5` to `4.4.1` - Add `cozy-logger` (requirement of [email protected]) These updates also solve a dependency problem on some apps. ``` error An unexpected error occurred: "expected hoisted manifest for \"cozy-bar#cozy-client#cozy-flags#cozy-client\"" ```
This parameter is used to indicate to cozy-bar that it is in reverse theme (black, by default white). This commit allows with this condition to change the icon `icon-cozy-home.svg` by `icon-cozy-home-inverted.svg`
The floating Claudy button creates problems to access the action below it so that’s why we remove it for the moment
Hide openwith if has subscription
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal is not to merge v7 into v8, but to keep track of the differences between the two versions, and ideally pushing/pulling what should be mutualised between the two versions