Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deps/upgrade deps #2189

Draft
wants to merge 86 commits into
base: master
Choose a base branch
from
Draft

Deps/upgrade deps #2189

wants to merge 86 commits into from

Conversation

taratatach
Copy link
Member

Please make sure the following boxes are checked:

  • PR is not too big
  • it improves UX & DX in some way
  • it includes unit tests matching the implementation changes
  • it includes scenarios matching a new behaviour or has been manually tested
  • it includes relevant documentation

  As an experiment, we propose to open the web Cozy Home in a Desktop
  window when pressing the `Ctrl` key while clicking on the `Open Cozy`
  button in the main window.

  Navigation in the Cozy from there will happen in the same window.
  When clicking a file or folder path in the main Desktop window, we
  open said file or folder with the default application for this file
  type or in the local OS file explorer.

  We will now offer to open them in Cozy Drive web when pressing the
  `Ctrl` key while clicking.
  This also works when clicking on the `Open Folder` button (i.e. it
  will open the root folder).
  Some error messages displayed in the main Desktop window contain the
  name of the impacted document. This name can be clicked to open the
  parent folder of the document in the local OS file explorer to help
  the user in finding the document and take appropriate actions to fix
  the issue.

  However, some errors can only be solved in the remote Cozy. For
  example, when a remote file name contains characters forbidden by the
  local OS, the file won't be downloaded at all until the name is
  changed and thus can't be found in the local file explorer.

  For these errors, we will now open the parent folder in Cozy Drive
  web.
@taratatach taratatach force-pushed the deps/upgrade-deps branch 12 times, most recently from e9be102 to 9408d84 Compare January 11, 2022 14:55
  This is the latest non-ESM version of this package.
  The opn package has changed its name into open. We take the
  opportunity to upgrade it.
  This version requires at least Sentry server v20.6.0 so we also switch
  to our new Sentry server.
  For some reason we need to both ignore the module's folder in
  `.flowconfig` and stub its types via `flow-typed` (no defnitions for
  v17.x are available at the moment) for flow to stop giving the
  following error on the `require` call:

  Cannot resolve module /home/erwan/repositories/cozy/desktop/node_modules/yargs/index.cjs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant