-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deps/upgrade deps #2189
Draft
taratatach
wants to merge
86
commits into
master
Choose a base branch
from
deps/upgrade-deps
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Deps/upgrade deps #2189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As an experiment, we propose to open the web Cozy Home in a Desktop window when pressing the `Ctrl` key while clicking on the `Open Cozy` button in the main window. Navigation in the Cozy from there will happen in the same window.
When clicking a file or folder path in the main Desktop window, we open said file or folder with the default application for this file type or in the local OS file explorer. We will now offer to open them in Cozy Drive web when pressing the `Ctrl` key while clicking. This also works when clicking on the `Open Folder` button (i.e. it will open the root folder).
Some error messages displayed in the main Desktop window contain the name of the impacted document. This name can be clicked to open the parent folder of the document in the local OS file explorer to help the user in finding the document and take appropriate actions to fix the issue. However, some errors can only be solved in the remote Cozy. For example, when a remote file name contains characters forbidden by the local OS, the file won't be downloaded at all until the name is changed and thus can't be found in the local file explorer. For these errors, we will now open the parent folder in Cozy Drive web.
taratatach
force-pushed
the
deps/upgrade-deps
branch
12 times, most recently
from
January 11, 2022 14:55
e9be102
to
9408d84
Compare
This package doesn't seem used anymore.
This is the latest non-ESM version of auto-bind.
This is the latest non-ESM version of this package.
The opn package has changed its name into open. We take the opportunity to upgrade it.
This version requires at least Sentry server v20.6.0 so we also switch to our new Sentry server.
For some reason we need to both ignore the module's folder in `.flowconfig` and stub its types via `flow-typed` (no defnitions for v17.x are available at the moment) for flow to stop giving the following error on the `require` call: Cannot resolve module /home/erwan/repositories/cozy/desktop/node_modules/yargs/index.cjs
taratatach
force-pushed
the
deps/upgrade-deps
branch
from
January 11, 2022 18:27
10672b5
to
9ddcae0
Compare
Fix scenarios remote trash conflicts sufix replacement. Again
taratatach
force-pushed
the
deps/upgrade-deps
branch
from
January 11, 2022 21:21
9ddcae0
to
5eff319
Compare
We also stub sinon based on sinon v7 type definitions to fix new lint errors.
taratatach
force-pushed
the
master
branch
2 times, most recently
from
January 18, 2022 15:35
8d7d624
to
18fc74a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please make sure the following boxes are checked: