Skip to content

ICS20: Correction to the denom in the sequence diagram #1229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

ivan-gavran
Copy link

This PR addresses one imprecision in ICS20 README that may cause confusion in otherwise very helpful sequence diagram example.

In the diagram illustrating multi-chain token transfer, there is a mistake in the denoms (in the last transaction):

  • B should be burning transfer/ChannelToA/denom (instead of transfer/ChannelToB/transfer/ChannelToA/denom)
  • B should be sending to A transfer/ChannelToA/denom (instead of transfer/ChannelToB/transfer/ChannelToA/denom)
  • A should be unlocking denom (instead of transfer/channelToA/denom)

@ivan-gavran ivan-gavran requested a review from AdityaSripal as a code owner May 22, 2025 10:01
Copy link
Contributor

@chipshort chipshort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice finding, I just stumbled upon the same thing.
I'm not a maintainer here, but some suggestions inline.

@ivan-gavran
Copy link
Author

Nice finding, I just stumbled upon the same thing. I'm not a maintainer here, but some suggestions inline.

Thanks for paying such a close attention!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants