fix: add break label in ws loop to properly escape outer loop #347
+5
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Addresses: EVM-168
The WebSocket logic conditionally uses
return
,continue
, andbreak
as part of its control flow. However, thebreak
statements inside theswitch
block is a no-op as it just exits the switch (which will happen anyways as it's the last statement in the case).If the original intent is to exit the read loop and stop the socket flow entirely, we need a label for the outer loop and
break
that instead.Author Checklist
I have...
main
branchReviewers Checklist
I have...
Unreleased
section inCHANGELOG.md