Skip to content

(chore): move feemarket update BaseFee to EndBlock #190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 30, 2025

Conversation

vladjdk
Copy link
Member

@vladjdk vladjdk commented May 29, 2025

Moves the feemarket base fee updates to the end of the block for easier gas fee estimation.

Closes: #123

@vladjdk vladjdk merged commit b2b7947 into main May 30, 2025
17 checks passed
@vladjdk vladjdk deleted the vlad/fee-market-endblock branch May 30, 2025 21:48
@0xbcdev
Copy link

0xbcdev commented Jun 1, 2025

Hi @Eric-Warehime and @vladjdk , I believe this PR is missing needed adjustment corresponding to the old BeginBlock logic.

Like this:

baseFee := k.feeMarketWrapper.CalculateBaseFee(ctx)

@Eric-Warehime
Copy link
Contributor

Hi @Eric-Warehime and @vladjdk , I believe this PR is missing needed adjustment corresponding to the old BeginBlock logic.

Like this:

baseFee := k.feeMarketWrapper.CalculateBaseFee(ctx)

@0xbcdev Can you expand on the issue you see here? It seems like the CalculateBaseFee call in the grpc handler is unnecessary now but it doesn't seem strictly incorrect to recalculate it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improvement Request: Move x/feemarket base fee calculation to EndBlocker and use in the next block
3 participants