(feat)!: upgrade to geth 1.13 #181
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* feat(x/erc20): add allowance state * test(x/erc20): add unit test for Allowance * fix(x/erc20): add deleteAllowances method and modify genesis validation * fix(x/erc20): validation of SetAllowance/GetAllowance and InitGenesis * test(x/erc20) add test cases for UnsafeSetAllowance * chore: fix lint
fix owner == sender case
…le-State-Writes fix: apply patch ISA-2025-004: Partial Precompile State Writes
feat: implement eth_getBlockReceipts endpoint
vladjdk
commented
May 23, 2025
| Expect(s.network.NextBlock()).To(BeNil()) | ||
|
|
||
| balRes, err := s.grpcHandler.GetBalanceFromBank(s.keyring.GetAccAddr(0), s.bondDenom) | ||
| Expect(err).To(BeNil()) | ||
| finalBalance := balRes.Balance | ||
| fees := math.NewIntFromUint64(txRes.GasUsed).Mul(math.NewIntFromBigInt(txArgs.GasPrice)) | ||
| Expect(finalBalance.Amount.Equal(initialBalance.Amount.Sub(fees))).To(BeTrue(), "expected final balance must be initial balance minus any gas spent") | ||
| expectedGasCost := math.NewInt(79_416_000_000_000) |
There was a problem hiding this comment.
Gas increased from 79_415_000_000_000 to 79_416_000_000_000. My theory is it's a small opcode gas diff with the new geth, but not 100% sure
| if stateObject == nil { | ||
| return | ||
| } | ||
| s.SelfDestruct(addr) |
There was a problem hiding this comment.
This is not equivalent to upstream. The SelfDestruct6780 call should only run on contracts which were created in the same txn.
There was a problem hiding this comment.
I think we'll need CreateContract added in here--we should track that against 1.15 upgrade and leave as is.
There was a problem hiding this comment.
Added this thread in the todos
Eric-Warehime
approved these changes
May 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
forks #116