-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update tutorial notebooks to use gammapy dev version #114
Conversation
…same fluxpointcontainer
…s in same fluxpoints container
Codecov Report
@@ Coverage Diff @@
## master #114 +/- ##
=======================================
Coverage 96.99% 96.99%
=======================================
Files 30 30
Lines 2233 2233
=======================================
Hits 2166 2166
Misses 67 67
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
Dear @jepcor97, apologies for replying so late and thanks a lot for the effort of updating the notebooks. I do not like the idea of deleting data points with repeated energies in the dataset. This would solve the issue for the PKS1510-089 dataset, for which, thanks to Julian, we solved the problem of provenance. I contacted the authors of the Mrk421 2011 to ask if they had the MWL SED ordered by instrument, but did not receive any answer so far. I suggest we make an other attempt - I am writing to them now, and if we do not manage, then let us simply change the dataset! I am sure we can find another MWL SED, even from the same Mrk421. As I said I do not like the idea of canceling measurements just because we cannot make flux points with them. Thanks for your work Juan. |
Since that dataset is "iconic" we can also consider keeping it and simply show an example of fit with |
Hi @cosimoNigro, |
@jepcor97, I added Thanks anyhow for your work. |
This PR modifies the notebooks so they are able to run with gammapy dev version.
Changes in this PR:
Mrk421_2011.ecsv
andPKS1510-089_2015b.ecsv
removing points with repeeated energy since they could not be loaded by gammapy; as a workaround until this possibility is implemented.FluxPoints
instances don't have an accesible.data
attribute anymore, and it gave errors.kwargs
passed to plot) since the names had changed and they were not anymore compatible.