Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix querier panic when marshaling QueryResultRequest #6601

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

SungJin1212
Copy link
Contributor

@SungJin1212 SungJin1212 commented Feb 24, 2025

This is PR fixes querier panic when marshaling QueryResultRequest.

Which issue(s) this PR fixes:
Fixes #6599

Checklist

  • Tests updated
  • Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

@SungJin1212 SungJin1212 force-pushed the Fix-query-scheduler-bug branch 3 times, most recently from ae1727a to a516c05 Compare February 25, 2025 09:49
@SungJin1212 SungJin1212 changed the title Reproduce querier panic Fix querier panic when marshaling QueryResultRequest Feb 25, 2025
@SungJin1212 SungJin1212 force-pushed the Fix-query-scheduler-bug branch 6 times, most recently from ec0ff63 to 09c8b35 Compare February 26, 2025 01:11
@SungJin1212 SungJin1212 force-pushed the Fix-query-scheduler-bug branch from 09c8b35 to 78b4646 Compare February 27, 2025 01:19
Copy link
Member

@alanprot alanprot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM! thanks

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Mar 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/querier lgtm This PR has been approved by a maintainer size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Querier panic when marshaling frontendv2pb.(*QueryResultRequest)
3 participants