Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove SecurityManager #79

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Remove SecurityManager #79

wants to merge 9 commits into from

Conversation

kcpeppe
Copy link
Contributor

@kcpeppe kcpeppe commented Dec 6, 2024

Bumped JDK version to 17

The SecurityManager was removed resulting in the tests that used the SecurityManager to prevent the call to System.exit from causing the JVM to exit in the middle of the test. The solution was to replace the System.exit calls with a call to a method that throws the appropriate exceptions. The tests were adjusted to ensure that the appropriate exceptions where thrown. Code in the main() method was moved into a separate method to separate configuration from flow control. This allows the tests to complete prior to JVM exit thus fixing Surefire failures.

@kcpeppe
Copy link
Contributor Author

kcpeppe commented Dec 6, 2024

not sure why there were commit conflicts but they're not resolved.

@earthling-amzn
Copy link
Contributor

Oops - I made similar changes in this PR: https://github.com/corretto/heapothesys/pull/78/files (after filing this ticket: #77). I should have been more clear in our discussion that I would address the Security Manager issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants