Remove SecurityManager #79
Closed
+50
−38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
not sure why there were commit conflicts but they're not resolved. |
|
Oops - I made similar changes in this PR: https://github.com/corretto/heapothesys/pull/78/files (after filing this ticket: #77). I should have been more clear in our discussion that I would address the Security Manager issues. |
|
Thank you for the contribution. I'm closing this without merging because similar changes were made at the same time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumped JDK version to 17
The SecurityManager was removed resulting in the tests that used the SecurityManager to prevent the call to System.exit from causing the JVM to exit in the middle of the test. The solution was to replace the System.exit calls with a call to a method that throws the appropriate exceptions. The tests were adjusted to ensure that the appropriate exceptions where thrown. Code in the main() method was moved into a separate method to separate configuration from flow control. This allows the tests to complete prior to JVM exit thus fixing Surefire failures.