Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 2.18 screenshots #2452

Merged
merged 3 commits into from
Feb 22, 2022
Merged

Release 2.18 screenshots #2452

merged 3 commits into from
Feb 22, 2022

Conversation

dsarkar
Copy link
Member

@dsarkar dsarkar commented Feb 20, 2022

Internal Tracking ID: EXPOSUREAPP-11663

@dsarkar dsarkar requested a review from a team February 20, 2022 14:10
@dsarkar dsarkar self-assigned this Feb 20, 2022
@dsarkar dsarkar requested a review from larswmh February 20, 2022 14:10
@dsarkar dsarkar added Fix 2.18 screenshots New Screenshots provided labels Feb 20, 2022
@dsarkar dsarkar mentioned this pull request Feb 20, 2022
6 tasks
@MikeMcC399
Copy link
Contributor

@dsarkar
As mentioned by @Marcono1234 relating to older screenshot versions, there are mistakes in the screenshot numbering in the alt texts. For example:

{ "filename": "/assets/screenshots/2-18/en/android/TraceLocationWarnInfoFragment", "alt": "Warn for others image 2 of 6" },
{ "filename": "/assets/screenshots/2-18/en/android/TraceLocationSelectionFragment", "alt": "Warn for others image 2 of 6" },

{ "filename": "/assets/screenshots/2-18/de/android/PersonOverviewFragment_two_g_plus_with_badge", "alt": "Certificates image 5 of 7"},
{ "filename": "/assets/screenshots/2-18/en/android/PersonDetailsFragment_cwa", "alt": "Certificates image 5 of 7"},
{ "filename": "/assets/screenshots/2-18/en/android/PersonDetailsFragment_cwa_2", "alt": "Certificates image 6 of 7"}

and so on through the whole file.

@Marcono1234
Copy link
Contributor

I have mentioned this in #2453, but my point was to not fix them manually (see description of that issue).

@MikeMcC399
Copy link
Contributor

@Marcono1234

I have mentioned this in #2453, but my point was to not fix them manually (see description of that issue).

@MikeMcC399
Copy link
Contributor

@larswmh
Thank you for correcting the alt text numbering!

Copy link
Contributor

@MikeMcC399 MikeMcC399 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't work out why my in-line comment is shown as "Outdated".

"<b>Anpassung der Darstellung für Auffrischungsimpfung:</b> Im Rahmen der Erinnerung für Auffrischungsimpfungen gibt es nun eine übersichtliche Darstellung. Weitere Informationen zu einer empfohlenen Auffrischungsimpfung sind nun durch das Tippen auf das Feld “Hinweis zur Auffrischimpfung” einsehbar. Siehe Screenshots 'Hinweis zur Auffrischimpfung' für sowohl <a href='#android_booster_note' target='_blank'>Android</a> als auch <a href='#ios_booster_note' target='_blank'>iOS</a> ",

shows the text I'm referring to.

Copy link
Contributor

@MikeMcC399 MikeMcC399 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@larswmh
Thanks for taking care of my comments!

@dsarkar
Copy link
Member Author

dsarkar commented Feb 22, 2022

@MikeMcC399 Many thanks for reviewing!

@dsarkar dsarkar merged commit d4ec45e into release/2.18 Feb 22, 2022
@dsarkar dsarkar deleted the feature/screenshots-2-18 branch February 22, 2022 09:57
larswmh added a commit that referenced this pull request Feb 23, 2022
* Update gulpfile.js

* Release 2.18 screenshots (#2452)

* update screenshots

* Adjust alts, fix screenshots, add text

* Use correct word for booster vaccination

* Update FAQ #admission_policy: Split into 5 entries (#2461)

* Update FAQ #admission_policy: Split into 5 entries

* Text adjustments and corrections

* Corrections

* Minor text adjustments

* Correct links and untranslated asset replacement (#2469)

* Blog 2.18 (#2472)

* Add blog

* Correct release time

Co-authored-by: Lars <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants