Pull request #7
Open
Pull request #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for PR. It looks good to me, but I have not working on this project long days... Did you test in your local environment to install the plugin with your updated code? |
|
Hi, yes, the code works perfectly. I really love your plugin btw and use it almost everyday. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, this could seem like a big pull request. But I just let IntelliJ inspect the code and update the syntax to Java 1.8.
Most important I edited SingleFileExecutionAction so, that the action will try to perform to the CMakeLists.txt on the same folder of the targeted source file. If that CMakeLists.txt doesn't exist, the action will be performed on the project's root CMakeLists.txt.