Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: deactivate use of missing module #307

Merged
merged 1 commit into from
Dec 11, 2024

Conversation

theseion
Copy link
Contributor

@theseion theseion commented Dec 11, 2024

The ngx_http_headers_more_filter_module isn't shipped in the upstream image, which currently breaks our images when nginx tries to load the module at startup.

Fixes #306

@theseion theseion requested a review from fzipi December 11, 2024 06:09
The ngx_http_headers_more_filter_module isn't shipped in the upstream
image, which currently breaks our images when nginx tries to load the
module at startup.

Fixes coreruleset#306
@theseion theseion force-pushed the fix/missing-nginx-module branch from 48ba2a3 to ee10080 Compare December 11, 2024 06:10
Copy link
Member

@fzipi fzipi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, then our tests were indeed failing somehow. nginx shouldn't have started.

@fzipi fzipi merged commit 5c7dd53 into coreruleset:main Dec 11, 2024
6 checks passed
@theseion theseion deleted the fix/missing-nginx-module branch December 12, 2024 07:10
@theseion
Copy link
Contributor Author

Yes, I thought the same

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ngx_http_headers_more_filter_module missing in 4.9.0 nginx Docker build
2 participants