plugins/netmask: Don't panic on invalid netmask #96
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like the error handling for this plugin is borked. I noticed
this while reading this code during my attempt to implement a DHCP
server. This also clarifies the error messages, since they were either
innaccurate, or duplicated which would make it impossible to tell which
code path the error actually came from.
NOTE: I didn't test this code, but it seems pretty trivial. I hope you have CI, but since this bug got through, then maybe not?