catch NPEs when calling replaceTrack #780
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @patrick-tresp thank you for your PR, can you revert the version increment, it is made during release only. Then I will test and release. |
|
Notice that next release will also include this fix for nil sender #770 |
nice, thank you ,reverted already. |
|
Thx will for review fix. |
hthetiot
approved these changes
Nov 4, 2023
|
Thank you @patrick-tresp , that why i dont close PR or Issues even after a while, you never know. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have addressed the issue of Null Pointer Exceptions in the iosrtcPlugin#RTCPeerConnection_RTCRtpSender_replaceTrack() method. I am using this plugin in a capacitor project where it can lead to app crashes without checking for nil values before accessing their properties.
Early Existence Checks: I have introduced early existence checks to ensure that critical objects, such as pluginRTCPeerConnection and pluginRTCRptSender, are not nil before attempting to use them.
Graceful Handling of Missing Objects: In case any of these objects are not found, I now emit error messages with informative details to assist with debugging and troubleshooting.
Safety for Optional Values: I have utilized Swift's optional binding (if let) to safely unwrap and use optional values like pluginMediaStreamTrack.