Fix issues #2834
Open
Fix issues #2834
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@miles-six is attempting to deploy a commit to the coral-xyz Team on Vercel. A member of the Team first needs to authorize it. |
|
@acheroncrypto hope this pr is helpful for you |
mikemaccana
reviewed
Apr 25, 2024
| @@ -114,7 +114,7 @@ mod tests { | |||
| #[test] | |||
| #[should_panic] | |||
| fn test_cluster_bad_parse() { | |||
| let bad_url = "httq://my_custom_url.test.net"; | |||
| let bad_url = "http://my_custom_url.test.net"; | |||
There was a problem hiding this comment.
This is deliberately a bad_url and designed to make the program panic. See test_cluster_bad_parse()
There was a problem hiding this comment.
lol the bot author needs to make it write better PR titles - 'fix issues' 🤦🏼♂️
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have been studying this repository for a long time, and whenever I come across a typo, I fix it.
I discovered 10 typos in a total of 9 files. Then I merged them together.
The code quality is exceptionally high, so sincerely hope my PR can help make this repository more standardized.