Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimized the printing of versions used Hashset #2800

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

vishalsinghji
Copy link

No description provided.

Copy link

vercel bot commented Jan 31, 2024

@vishalsinghji is attempting to deploy a commit to the coral-xyz Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Collaborator

@acheroncrypto acheroncrypto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks but what are we optimizing here actually?

@vishalsinghji
Copy link
Author

Thanks but what are we optimizing here actually?

  1. Used a HashSet to efficiently check if a version is installed.
  2. Extracted the common print logic into a helper function (print_version_info).
  3. Simplified the loop and conditionals for printing available versions.
  4. Removed unnecessary cloning and modified the iteration to work directly with references.
  5. Consolidated and cleaned up the code for better readability.

@vishalsinghji
Copy link
Author

@acheroncrypto Can you Review this PR ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants