client: make RequestBuilder Send when building async #2734
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Solana’s Signer trait has neither Send nor Sync bound. Lack of those bonds trickles down to RequestBuilder type which contains a `signers: Vec<&dyn Signer>` field. Introduce a new `nonblocking::Signer` trait which adds `Send` bound and is automatically implemented on any type which implement’s Solana’s `Signer` trait and is `Send`. As this is added to `nonblocking` module, it’s only used when using `async` feature. With that present, use it in RequestBuilder struct making it `Send`.
|
@mina86 is attempting to deploy a commit to the coral-xyz Team on Vercel. A member of the Team first needs to authorize it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solana’s Signer trait has neither Send nor Sync bound. Lack of those
bonds trickles down to RequestBuilder type which contains a
signers: Vec<&dyn Signer>field.Introduce a new
nonblocking::Signertrait which addsSendboundand is automatically implemented on any type which implement’s
Solana’s
Signertrait and isSend. As this is added tononblockingmodule, it’s only used when usingasyncfeature.With that present, use it in RequestBuilder struct making it
Send.