Time exchanges can now be made between organisations #639
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To do this, 3 transfers are made: member1 --> organization1; organization1 --> organization2; organization2 --> member2. In order to reuse the implemented code and not make it unnecessarily long, it was necessary to make some modifications to the implemented code. Issue #638.
the transfer between users from different organisations has been carefully tested and tests like those of transfer_factory which required a parameter. Issue #638.
Sergi says that an organisation can also give time for an offer from another organisation so now it also works if an admin chooses an organisation's account. I have also refactored my code a bit. Issue #638.
franpb14
commented
May 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The feature is working exactly as shown in this drawing. Here you can see it working in the following video and the full trace it would do:
Issue638.mp4
If the source account is the organisation the first trace between first member and organisation would not be there but the rest is the same. When a member makes a donation it is the same, except that they cannot choose the source (as they do with current transfers).
For the implementation I have adapted the current transfers and therefore also had to change some tests (minor changes and specification of a new context).
closes #638.