Decouple members and users resources #260
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
enricostano
commented
Aug 23, 2017
app/controllers/users_controller.rb
Outdated
| @movements = @member.movements.order("created_at DESC").page(params[:page]). | ||
| per(10) | ||
| @user = User.find_by_id(params[:id]) | ||
| raise unless @user |
enricostano
commented
Aug 23, 2017
|
|
||
| it 'renders a page with a link to give time to the user' do | ||
| get :show, id: user | ||
| expect(response.body).to include("<a href=\"/users/#{user.id}/give_time\">") |
There was a problem hiding this comment.
@sseerrggii el boton "Give time" lo deberiamos dejar solo en el perfil de member verdad? Lo deberiamos quitar del perfil de usuario ya que esta pagina ya no esta relacionada con ninguna organizacion. Correcto?
There was a problem hiding this comment.
Correcto! Solo en member 👍
enricostano
commented
Sep 18, 2017
| @@ -3,7 +3,7 @@ | |||
| <td> | |||
| <img ng-src="{{user.avatar}}" height: "32px" width: "32px"> | |||
| </td> | |||
| <td>{{user.member_id}}</td> | |||
| <td>{{user.member_uid}}</td> | |||
There was a problem hiding this comment.
member.member_uid?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to some design restriction decided when TO users could only pertain to one time bank, the
UserandMemberresources were coupled and often used interchangeably. Now that we want to introduce the concept of "discover a time bank near to you" and multiple memberships we need to refactor and break this coupling.This PR is related to #250, but independent. Although would be nice to merge this one first.