Skip to content

[PERTE-333] Use logistics actions on task view #1989

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 81 commits into
base: master
Choose a base branch
from
Draft

[PERTE-333] Use logistics actions on task view #1989

wants to merge 81 commits into from

Conversation

JuanIgAcosta
Copy link
Contributor

@JuanIgAcosta JuanIgAcosta commented May 5, 2025 •
edited by diegomanuel
Loading

Issue: #333

Related issue: coopcycle/coopcycle#313
Related PR: #1983

The problem arises because both dispatcher and courier screens/sections uses the same "task detail view".
Starting the task from there, when the backend responds "OK", we update the redux state from courier instead of logistics.

Tasks:

  • Starting the task should update redux state from logistics and/or courier.
  • Review if there is no other remaining action/call with this kind of problem at any other shared component between screens/sections.
  • Make an e2e test for "start task" action, making sure the redux state has the right updated data.

warmijusti and others added 30 commits April 21, 2025 12:33
@warmijusti
add bulkAssignTasks mutation
7741eeb
@warmijusti
update _bulkAssign
5a43998
@JuanIgAcosta
Fix endpoint's call
e2725cd
@warmijusti
update _assignTask
4d9ab3a
@warmijusti
update assing using slice - update class to functional component
32ce60e
@warmijusti
clean imports and comments
a9d15aa
@warmijusti
clean imports and comments
c4fbdb5
@warmijusti
updates unassig to use slice
11eee2a
@warmijusti
rename slice
7b17bc6
@warmijusti
new getTasksForUser
1c9bac0
@warmijusti
add comments
3fb5360
@warmijusti
fix assign / unassign
28f8981
@JuanIgAcosta
Refactor: getTasksForUser -> getUserTasks
d80f3a4
@JuanIgAcosta
Added slice setTourItems
2ea765c
@JuanIgAcosta
Assign task with related tasks and tours using hook
bb84fcc
@JuanIgAcosta
Bulk assign tasks with related tasks and tours using hook
a0d0d8d
@JuanIgAcosta
Unassign task using hook
dcd8d05
@JuanIgAcosta
Update task and taskList on success
c677986
@JuanIgAcosta
Added function getAssignedTask
63b6db2
@JuanIgAcosta
Unassign task with related tasks and tours using hook
95eecbd
@JuanIgAcosta
Show spinner on assign/unassign task/s and handle errors
b6b0951
@JuanIgAcosta
Added TODO
ced5715
@JuanIgAcosta
Added actions
274d76f
@JuanIgAcosta
Show spinner on assign/unassign task/s and handle errors
f0e13be
@JuanIgAcosta
Added TODO
632c4ff
@JuanIgAcosta
Remove unused assign/unassign functions from Dispatch/actions
70607f4
@JuanIgAcosta
Remove unused actions
31ae4ee
@JuanIgAcosta
Fixed tests
c24d1d8
@JuanIgAcosta
Format file
615061e
@JuanIgAcosta
Assign task with related tasks and tours using hook in AssignTasks
e26bb79
@diegomanuel diegomanuel changed the title Bugfix/333 use logistics actions on task view [PERTE-333] Use logistics actions on task view May 5, 2025
@diegomanuel diegomanuel added bug Dispatch Interface An issue related to dispatch´s interface. Ex: The admin and orders dashboards, using matomo, tags Cooperative: Transversal Concepts labels May 5, 2025
@diegomanuel diegomanuel mentioned this pull request May 5, 2025
Merged
4 tasks
JuanchoAcosta and others added 24 commits May 6, 2025 11:28
@JuanchoAcosta
Fix tests
854a7d7
@JuanchoAcosta
Moved utils to shared folder
012a33d
@JuanchoAcosta
Define createTaskList actions with redux toolkit
4543988
@JuanchoAcosta
Moved startTask actions to logistics
f2397db
@JuanchoAcosta
Moved markTaskDone actions to logistics
df726d1
@JuanchoAcosta
Moved markTaskFailed actions to logistics
acf2a4f
@JuanchoAcosta
Fix tests
7d131ba
@JuanchoAcosta
Fix: update redux status on startTask
447d865
@JuanchoAcosta
Fix unassign tasks
bc5bafa
@JuanchoAcosta
Merge branch 'feature/313-refactor-modification-of-TaskList-object' o…
7a573fc 
…f github.com:coopcycle/coopcycle-app into bugfix/333-use-logistics-actions-on-task-view
@JuanchoAcosta
A test is born
966bbe2
@JuanchoAcosta
baby steps
98d96c2
@JuanIgAcosta
Added utils to simplify code
adfaa03
@JuanIgAcosta
Fix repeated key warning
139343e
@JuanIgAcosta
Use itemsIds
3333562
@JuanchoAcosta
Added tests to getToursToUpdate
c30b128
@JuanchoAcosta
Fix tour's un/assignation
f381cbd
@diegomanuel
Adding missing imports.
65068ff
@JuanchoAcosta
Fix tests
e4dd9a7
@JuanchoAcosta
Merge branch 'feature/313-refactor-modification-of-TaskList-object' i…
d9fd135 
…nto bugfix/333-use-logistics-actions-on-task-view
@JuanchoAcosta
Added test 'should mark a task as started'
ba3b743
@JuanchoAcosta
Added test 'should mark a task as done'
e0db1c5
@JuanIgAcosta
Merge branch 'bugfix/333-use-logistics-actions-on-task-view' of githu…
a3c5209 
…b.com:coopcycle/coopcycle-app into bugfix/333-use-logistics-actions-on-task-view
@JuanIgAcosta
Split tests cases in different files
3c442d4
Base automatically changed from feature/313-refactor-modification-of-TaskList-object to master May 9, 2025 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@diegomanuel diegomanuel

@JuanIgAcosta JuanIgAcosta

@warmijusti warmijusti

@luanacuello luanacuello

Labels
bug Cooperative: Transversal Concepts Dispatch Interface An issue related to dispatch´s interface. Ex: The admin and orders dashboards, using matomo, tags
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@JuanIgAcosta @diegomanuel @warmijusti @luanacuello @JuanchoAcosta