-
Notifications
You must be signed in to change notification settings - Fork 34
[PERTE-235] Migrate to new v2 endpoints+events for tasks, task_list and tours #1968
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…couriers' into feature/235-update-task-list-endpoint
…235-update-task-list-endpoint
…opcycle/coopcycle-app into feature/235-update-task-list-endpoint
…opcycle/coopcycle-app into feature/235-update-task-list-endpoint
…r item's "@id" property).
…`unassignTask` to work even if some task fails with 500.
…y unassigned but the tour where it belogs to is not.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hello i noticed two problems
- problem when an empty tour is inserted into the tasklist -> the thing goes mad
- seems flaky when reordering tasks into a tasklist, sometimes update, sometimes not
I dont really understand from where the problem comes from, as if we use v2:task_list:updated event we just have to copy the data from there
see GIFs below
…opcycle/coopcycle-app into feature/235-update-task-list-endpoint
It should be solved with our latests adjustments! |
How to reproduce?!
|
In which screen? We saw that problem from time to time already happening from the beginning, but it was always harmless. |
Issue: #235
Relates to PR: coopcycle/coopcycle-web#4944
Start using the new enpoints described in the issue.
master
here and test that everything works just fine! 😅PUT /api/tours/{id}
to replace it with the tour's remaining tasks (even if it's left empty).import { createAction } from 'redux-actions';
byimport { createAction } from '@reduxjs/toolkit'
just at file: redux/Dispatch/actions.js