fix: always pull latest compose file image

[Patrick3131]

Changes

• Always pull latest images if build pack is not docker image

Issues

• fix [Bug]: Build server + Git, latest image not pulled #3537

[djsisson]

@Patrick3131 you can add pull_policy: always to each service where you need the image pulled everytime.

imo forcing this on everyone for every image, doesn't seem great to me

[Patrick3131]

Hey @djsisson
Thank you for your input.
It makes sense what you are saying.

Here in this PR by @lucienbl we are using a similar approach, the only difference is (correct me if I am wrong) that we are using the server to build and are not just pulling the images from a registry. So to be consistent, we should use the same approach for both use cases, what do you think?

[lucienbl]

Hey @djsisson what you say completely makes sense and that was my thought too, however the problem is that AFAIK we do not have 'easy' access to the generated compose file when using Nixpacks, which is the problem here. But maybe having an option to have the force pull or not would be a better solution as each user could choose what he wants.

Could be an option here for example :

[djsisson]

the build server entry suffers from the same issue, you're requesting to repull everything, just means you can easily hit rate limits on external repo hubs.

To clarify, the above fix, means those with a compose file have all their services request a repull, so if its a big stack, that's the issue, for single deployments, this isn't an issue, but below would be the ideal fix.

you would add an entry here for pull_policy: always this works for all paths for only the service that is being built that aren't using a compose file,

coolify/app/Jobs/ApplicationDeploymentJob.php

Line 1727 in 717f0f2

'image' => $this->production_image_name,

[lucienbl]

That makes sense, thanks for the hint !

[djsisson]

I will reiterate the first post, if you are using a compose that is using an externally built image, you need to just add

services:
  service:
    image: xxx
    pull_policy: always

this fixes issue of not always pulling your newly built image