Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UPD]Update screenshots and Sections #2

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

[UPD]Update screenshots and Sections #2

wants to merge 7 commits into from

Conversation

lyabs243
Copy link

Update some screnshots and add some sections on the user manual, but the layout of the elements is not good

Copy link
Member

@jcbrand jcbrand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @lyabs243

Thank you for your work on this so far!

I see you've been using Pàdé for the screenshots that you made. It would be better if the screenshots are made only with Converse, because there are subtle differences between the UI of Converse and Pàdé and this user manual is only for Converse.

The Pàdé could re-use this user manual, but then they would have to user their own screenshots or use screenshots of vanilla Converse.

Soon in the coming days there will be a new release of Converse with an updated UI, so I suggest you wait for that release before you make screenshots.

source/index.rst Outdated Show resolved Hide resolved

To join a group, click the **Add a group** link in the **GroupChats** tab. This will
slide open a new dialog in which you can type the GroupChat adress of the group you'd
like to add.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like you copied this text from other parts of the user manual.

The latest versions of Converse doesn't have tabs and it uses modals, so there's nothing that "slides open", so this text needs to be updated.

Instead of "tabs", we now have "sections", the "Groupchats" section and the "Contacts" section.
And instead of a dialog that slides open, we now have a "modal" that "appears".

source/index.rst Outdated Show resolved Hide resolved
source/index.rst Outdated Show resolved Hide resolved
@lyabs243
Copy link
Author

lyabs243 commented Jan 9, 2019

@jcbrand understood i am workink to make all changes.

@lyabs243
Copy link
Author

@jcbrand i make some changes on description of some functionalities but for screenshots i use conversejs.org but to me is in frensh even if my browser is english

Copy link
Member

@jcbrand jcbrand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @lyabs243

Thank you for your work on this, and sorry for taking so long to respond again.
Please see the new review comments that I have left.

a poor security score (colored in red).

Choosing a username
~~~~~~~~~~~~~~~~~~~
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @lyabs243, why did you remove the text below? Now with the newer version in your branch, there is no information on how to register an XMPP account.

:align: left
:alt: The registration panel of the converse.js control box.

The registration panel of converse.js

With converse.js you can register a new XMPP account on any publically available XMPP provider.
To do so, click the **Register** tab on the chat client.
To do so, click the **Register** link to the bottom of panel.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The link doesn't say Register, it says Create an account

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, it would be better to say "below the login form", instead of "to the bottom of the panel"

:align: left
:alt: The registration form for an XMPP account at conversejs.org

The registration form
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did you not replace this image with a newer version?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants