Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(config-nx-scopes): fix for projects without explicit targets #4261

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

gperdomor
Copy link
Contributor

@gperdomor gperdomor commented Jan 28, 2025

Description

This PR remove the filter projects by targets property

Motivation and Context

Currently the targets property is not always explicitly defined, now most of the task are inferred using Crystal.

Usage examples

N/A

// commitlint.config.js
import { utils } from '@commitlint/config-nx-scopes';

module.exports = {
  extends: ['@commitlint/config-conventional', '@commitlint/config-nx-scopes'],
  rules: {
    'scope-enum': async (ctx) => [2, 'always', ['repo', 'deps', 'release', ...(await utils.getProjects(ctx))]],
  },
};
echo "your commit message here" | commitlint # fails/passes

How Has This Been Tested?

In my own Nx 20.4.0 workspace, where next apps are created without the targets property and the project is ignored by the plugin unless I remove the line removed in this PR

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant