WIP: set a default policy group name #1094
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
build PR |
1 similar comment
|
build PR |
|
build pr |
This also maps k8s namespace to EPG Signed-off-by: Ranjith <[email protected]>
vhosakot
reviewed
Dec 20, 2017
| k8s-test: first_master_make_targets:=run-build | ||
| k8s-test: export VAGRANT_CWD:=$(PWD)/vagrant/k8s | ||
| k8s-test: export CONTIV_K8S_USE_KUBEADM:=1 CONTIV_NODES:=3 PYTHONIOENCODING:=utf-8 | ||
| k8s-test: k8s-cluster make-on-first-master-dep |
There was a problem hiding this comment.
Will these duplicate targets be combined into a single k8s-test?
vhosakot
reviewed
Dec 20, 2017
| // Pods need to be in a group to allow policies to be applied after pod | ||
| // creation, if a group is not specified by the user, then place pod | ||
| // into a group shared across the pod's namespace, as contiv group is part | ||
| // of a network and network is in a k8s namespace |
There was a problem hiding this comment.
Can you add the above four lines in the description of this PR so that reviewers know what it does. Also, curious to know if this approach decreased the runtime of system tests? If so, by how much?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pods that did not specify a contiv group will be
assigned a default based on a name pattern:
"ns-" + + "-default"