Update CocoaPods Deployment Targets #387
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like the test failures are due to a live network request failing. |
|
Just an FYI, bumping deployment targets is breaking for anything depending on it with a lower deployment target, so this would require a major version bump. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#331 and #386 are caused by the CocoaPods deployment targets being too far out of date. This PR brings them up to the iOS 10 generation. Technically these will still produce warnings in Xcode but they can be easily ignored and won't break at compile time any more.
This PR also updates the Ruby environment to the latest Ruby version, latest dependencies, and adds a
.ruby-gemsetfor RVM (and rbenv with the right configuration I think). Also removes Boris from the authors, as I don't believe he can support the framework. Let me know if there should be some other contact.