UI - Playwright POC - Templating #435
Conversation
mayurilahane
force-pushed
the
mlahane/template_add_playwright
branch
2 times, most recently
from
3c765e0 to
58239b5
Compare
| const architectureFilterButton = page.getByRole('button', { name: 'Select architecture' }); | ||
| await architectureFilterButton.click() |
There was a problem hiding this comment.
Do you use architectureFilterButton more than once? If not, maybe no need to actually save it in variable.
| const versionFilterButton = page.getByRole('button', { name: 'Select version' }); | ||
| await versionFilterButton.click(); |
| await page.getByRole('option', { name: 'x86_64' }).click(); | ||
| const versionFilterButton = page.getByRole('button', { name: 'Select version' }); | ||
| await versionFilterButton.click(); | ||
| await page.getByRole('menuitem', { name: 'el8' }).locator('label').click(); |
There was a problem hiding this comment.
Interesting that you actually need to click on the label, but if it is required, fair enough
There was a problem hiding this comment.
this did the work
await page.getByRole('option', { name: 'el8' }).click();
| await versionFilterButton.click(); | ||
| await page.getByRole('menuitem', { name: 'el8' }).locator('label').click(); | ||
| await page.getByRole('button', { name: 'Next' }).click(); | ||
| // select Red hat repos Checkbox optional |
There was a problem hiding this comment.
Is this comment for the next row? Because that does not select any repos. Same for the comment on line 21
There was a problem hiding this comment.
its a reminder to add that optional step i will make it clear thanks !
| await page.getByRole('button', { name: 'Next' }).click(); | ||
| // select checkbox for cutom repo optional | ||
| page.getByRole('button', { name: 'Next' }).click(); | ||
| await page.getByRole('radio', { name: 'use-latest-snapshot' }).fill('True'); |
There was a problem hiding this comment.
.fill(True) ? I though we should be using https://playwright.dev/docs/input#checkboxes-and-radio-buttons or is that not working?
There was a problem hiding this comment.
fixed it with the locator attribute
await page.locator('input[name="use-latest-snapshot"]').click();
| const nameInput = page.getByPlaceholder('Enter name'); | ||
| const descriptionInput = page.getByPlaceholder('Enter Description'); //optional | ||
| await nameInput.fill('demo_template'); | ||
| await descriptionInput.fill('test'); // optional |
| const descriptionInput = page.getByPlaceholder('Enter Description'); //optional | ||
| await nameInput.fill('demo_template'); | ||
| await descriptionInput.fill('test'); // optional | ||
| page.getByRole('button', { name: 'Next' }).click(); |
There was a problem hiding this comment.
without await it does not do much - I think :D
There was a problem hiding this comment.
yes right added it
| await descriptionInput.fill('test'); // optional | ||
| page.getByRole('button', { name: 'Next' }).click(); | ||
| // teamplate with system | ||
| page.getByRole('button').locator('pf-v5-c-menu-toggle__button'); |
There was a problem hiding this comment.
What is this selector used for? You need to do some assertion or waiting for some action
There was a problem hiding this comment.
its this "create template only" button
| page.getByRole('button', { name: 'Next' }).click(); | ||
| // teamplate with system | ||
| page.getByRole('button').locator('pf-v5-c-menu-toggle__button'); | ||
| page.getByRole('button', { name: 'Create template only' }).click(); |
There was a problem hiding this comment.
you need await. And then the test should continue and wait for the template to be created
There was a problem hiding this comment.
Added thanks !
mayurilahane
force-pushed
the
mlahane/template_add_playwright
branch
from
58239b5 to
6fa551b
Compare
Summary
Testing steps