Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address CVE-2024-3727 #22666

Conversation

TomSweeneyRedHat
Copy link
Member

This addrress the CVE-2024-3727 by pulling in the top of main for

c/image, c/common, and c/buildah, all of which have the fix.

Addresses: CVE-2024-3727
No associated Jira cards at the moment.

Does this PR introduce a user-facing change?

None

This addrress the CVE-2024-3727 by pulling in the top of main for

c/image, c/common, and c/buildah, all of which have the fix.

Addresses:  CVE-2024-3727
No associated Jira cards at the moment.

Signed-off-by: tomsweeneyredhat <[email protected]>
Copy link
Contributor

openshift-ci bot commented May 10, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: TomSweeneyRedHat

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 10, 2024
Copy link

Ephemeral COPR build failed. @containers/packit-build please check.

@mheon
Copy link
Member

mheon commented May 10, 2024

Bloat check failed. I'll add the label.

@mheon mheon added the bloat_approved Approve a PR in which binary file size grows by over 50k label May 10, 2024
@mheon
Copy link
Member

mheon commented May 10, 2024

I think there's an actual bug in a test that's failing.
<+015ms> # $ podman run --rm --mount source=/tmp/podman_bats.HT8hWQ/v2*,destination=/tmp/foobar, ro=false quay.io/libpod/testimage:20240123 touch /tmp/podman_bats.HT8hWQ/v2_EPFu0yWqTV

Note the space between /tmp/foobar, and ro=false

Not sure how this is passing on main right now?

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 13, 2024
@openshift-merge-robot
Copy link
Collaborator

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@Luap99
Copy link
Member

Luap99 commented May 13, 2024

I think there's an actual bug in a test that's failing. <+015ms> # $ podman run --rm --mount source=/tmp/podman_bats.HT8hWQ/v2*,destination=/tmp/foobar, ro=false quay.io/libpod/testimage:20240123 touch /tmp/podman_bats.HT8hWQ/v2_EPFu0yWqTV

Note the space between /tmp/foobar, and ro=false

Not sure how this is passing on main right now?

This fails because c/common returns a new error message, but the whole tests was broken and is fixed in #22638 so you just have to rebase.

Also in general before opening new vendor PR's it would be always good to first merge the existing ones.

@TomSweeneyRedHat
Copy link
Member Author

Something is totally scrozzled in my sandbox. I'm killing this and restarting.

@TomSweeneyRedHat TomSweeneyRedHat deleted the dev/tsweeney/bumpbuildahmain branch May 13, 2024 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bloat_approved Approve a PR in which binary file size grows by over 50k needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. release-note-none
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants