Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "container stop: kill conmon" #22662

Merged
merged 1 commit into from May 13, 2024
Merged

Revert "container stop: kill conmon" #22662

merged 1 commit into from May 13, 2024

Conversation

giuseppe
Copy link
Member

@giuseppe giuseppe commented May 9, 2024

the code was added 5 years ago. It is safe to assume such ancient conmon versions are not used anymore.

Does this PR introduce a user-facing change?

None

@giuseppe giuseppe added the No New Tests Allow PR to proceed without adding regression tests label May 9, 2024
@openshift-ci openshift-ci bot added release-note-none approved Indicates a PR has been approved by an approver from all required OWNERS files. labels May 9, 2024
@packit-as-a-service Packit-as-a-Service
Copy link

Ephemeral COPR build failed. @containers/packit-build please check.

@packit-as-a-service Packit-as-a-Service
Copy link

Cockpit tests failed for commit 5663138. @martinpitt, @jelly, @mvollmer please check.

@giuseppe giuseppe closed this May 9, 2024
@giuseppe
Revert "container stop: kill conmon"
8433a01 
This reverts commit 909ab59.

The workaround was added almost 5 years ago to workaround an issue
with old conmon releases.  It is safe to assume such ancient conmon
releases are not used anymore.

Signed-off-by: Giuseppe Scrivano <[email protected]>
@giuseppe giuseppe reopened this May 9, 2024
@giuseppe giuseppe force-pushed the drop-ancient-conmon-check branch from 5663138 to 8433a01 Compare May 9, 2024 20:50
@packit-as-a-service Packit-as-a-Service
Copy link

Ephemeral COPR build failed. @containers/packit-build please check.

@mheon
Copy link
Member

mheon commented May 10, 2024

LGTM

vrothberg
vrothberg approved these changes May 13, 2024
View reviewed changes
Copy link
Member

@vrothberg vrothberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vrothberg
Copy link
Member

[+0452s] # [12:32:29.065179259] $ minikube delete
[+0452s] # [12:32:29.254456746] * Deleting "minikube" in qemu2 ...
[+0452s] # * Removed all traces of the "minikube" cluster.
[+0452s] #
[+0452s] # [12:32:29.333574320] $ podman rmi --ignore localhost/podman-pause:5.1.0-dev-1715288324
[+0452s] # [12:32:29.433581325] Error: image used by dc47524eb166a95023d8e5085683ae8722f88ce0ed88bdf4c6d01e9d7dae5272: image is in use by a container: consider listing external containers and force-removing image

The flake looks like a legit race condition.

@giuseppe
Copy link
Member Author

[+0452s] # [12:32:29.065179259] $ minikube delete
[+0452s] # [12:32:29.254456746] * Deleting "minikube" in qemu2 ...
[+0452s] # * Removed all traces of the "minikube" cluster.
[+0452s] #
[+0452s] # [12:32:29.333574320] $ podman rmi --ignore localhost/podman-pause:5.1.0-dev-1715288324
[+0452s] # [12:32:29.433581325] Error: image used by dc47524eb166a95023d8e5085683ae8722f88ce0ed88bdf4c6d01e9d7dae5272: image is in use by a container: consider listing external containers and force-removing image

The flake looks like a legit race condition.

I've restarted it. I don't understand how killing conmon would have prevented this error (if anything, it prevents the podman cleanup process to run).

@vrothberg
Copy link
Member

I've restarted it. I don't understand how killing conmon would have prevented this error (if anything, it prevents the podman cleanup process to run).

Totally agree that PR doesn't cause the flake 👍

Luap99
Luap99 approved these changes May 13, 2024
View reviewed changes
Copy link
Member

@Luap99 Luap99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 13, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented May 13, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: giuseppe, Luap99, vrothberg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [Luap99,giuseppe,vrothberg]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit fcbe295 into containers:main May 13, 2024
88 of 90 checks passed
@edsantiago edsantiago mentioned this pull request May 15, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vrothberg vrothberg vrothberg approved these changes

@Luap99 Luap99 Luap99 approved these changes

Assignees

@Luap99 Luap99

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. No New Tests Allow PR to proceed without adding regression tests release-note-none
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@giuseppe @mheon @vrothberg @Luap99