-
Notifications
You must be signed in to change notification settings - Fork 268
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature(website): storybook docusaurus integration #7648
base: main
Are you sure you want to change the base?
feature(website): storybook docusaurus integration #7648
Conversation
0f675a4
to
1cea817
Compare
Here is a demo https://6672bf678132600ac54716c3--podman-desktop-pr.netlify.app/storybook?id=example-button--docs ℹ️ Special noteThe sidebar is very basic on purpose, I will need to improve it, but as it will probably be a lot of work, it will be made in a follow-up PR |
it looks like vale is broken |
Odd flashing when toggling between pages, but I assume that can mostly be fixed by having consistent light/dark mode? Also noticed some Storybook issues like inprogress not quite working, enums, hard to clear values, but those are separate. |
yeah this is very complicated, as the default value of the iframe is set to light mode, and the docusaurus page will send the theme value when the page is rendered. We can probably improve that later, but for now this little flickering is here.
Yeah, because all values are extracted from reflection on svelte component, we can improve those later |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you remove the job for storybook as now it's part of the website ?
Yes, sorry I forgot to mention it |
faef756
to
0cb16dc
Compare
Signed-off-by: axel7083 <[email protected]>
Signed-off-by: axel7083 <[email protected]>
Signed-off-by: axel7083 <[email protected]>
Signed-off-by: axel7083 <[email protected]>
Signed-off-by: axel7083 <[email protected]>
Signed-off-by: axel7083 <[email protected]>
Signed-off-by: axel7083 <[email protected]>
Signed-off-by: axel7083 <[email protected]>
Signed-off-by: axel7083 <[email protected]>
Signed-off-by: axel7083 <[email protected]>
Signed-off-by: axel7083 <[email protected]>
0cb16dc
to
d242524
Compare
What does this PR do?
First draft of the Storybook integration this pull request contains the following
A
Docusaurus
pluginThis plugin, which is located in
website/storybook.js
is responsible of generating the sidebar and populate the docusaurus build folder with the storybook sources.A react page
Once the plugin has generated a sidebar under the docusaurus format, a custom react page will use it to create a page located at
/storybook
.Screenshot / video of UI
TODO
What issues does this PR fix or reference?
Fixes #7438
How to test this PR?