chore: more use of slide toggle #7169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deboer-tim
requested review from
dgolovin and
lstocchi
and removed request for
a team
benoitf
approved these changes
May 11, 2024
lstocchi
approved these changes
May 13, 2024
We have toggle switches in several places, but none of them were the same code. This updates the existing SlideToggle to support a few more cases (properties, aria, label on left or right) and adds colors for light mode. The component is then reused for Settings > Preferences and Settings > Proxies. I had to make a couple judgement calls to make things consistent: - The switch (circle) is bigger than before in Preferences. - The proxy text gets dimmer when disabled/off, to match what was happening in preferences. - I added missing hover states, making each one step brighter to match Buttons, except I made the off-hover state purple to match other controls to let you know you can click on it. Signed-off-by: Tim deBoer <[email protected]>
|
Rebased to pick up conflicting changes in main. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
We have toggle switches in several places, but none of them were the same code. This updates the existing SlideToggle to support a few more cases (properties, aria, label on left or right) and adds colors for light mode. The component is then reused for Settings > Preferences and Settings > Proxies.
I had to make a couple judgement calls to make things consistent:
Screenshot / video of UI
Screen.Recording.2024-05-10.at.4.52.30.PM.mov
What issues does this PR fix or reference?
Fixes #7168.
How to test this PR?
Check toggles in Settings > Preferences and Settings > Proxies. Basic SlideToggle tests were missing, so I added and extended those.