Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove test containerfile #7163

Merged
merged 1 commit into from May 12, 2024
Merged

Conversation

cdrage
Copy link
Contributor

@cdrage cdrage commented May 10, 2024

chore: remove test containerfile

What does this PR do?

Removes an old bootc container file that is no longer needed / should
not be referenced (uses an old FROM, as well as very insecure RUN
command)

Screenshot / video of UI

N/A

What issues does this PR fix or reference?

N/A

How to test this PR?

N/A

Signed-off-by: Charlie Drage [email protected]

@cdrage cdrage requested review from benoitf and a team as code owners May 10, 2024 15:13
@cdrage cdrage requested review from axel7083 and lstocchi and removed request for a team May 10, 2024 15:13
Copy link
Contributor

@cbr7 cbr7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are you removing all three files? Only the bootable-containerfile should be removed, the other two are in use in tests.

### What does this PR do?

Removes an old bootc container file that is no longer needed / should
not be referenced (uses an old FROM, as well as very insecure RUN
command)

### Screenshot / video of UI

<!-- If this PR is changing UI, please include
screenshots or screencasts showing the difference -->

N/A

### What issues does this PR fix or reference?

<!-- Include any related issues from Podman Desktop
repository (or from another issue tracker). -->

N/A

### How to test this PR?

<!-- Please explain steps to verify the functionality,
do not forget to provide unit/component tests -->

N/A

Signed-off-by: Charlie Drage <[email protected]>
@cdrage
Copy link
Contributor Author

cdrage commented May 10, 2024

Why are you removing all three files? Only the bootable-containerfile should be removed, the other two are in use in tests.

Woops, I removed the directory instead of just the single file by mistake. Updated

@cbr7 cbr7 self-requested a review May 10, 2024 15:37
@cdrage cdrage merged commit d9fe1f5 into containers:main May 12, 2024
8 checks passed
@podman-desktop-bot podman-desktop-bot added this to the 1.11.0 milestone May 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants