Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Light mode for components in dashboard #7161

Merged
merged 2 commits into from May 16, 2024

Conversation

feloy
Copy link
Contributor

@feloy feloy commented May 10, 2024

Signed-off-by: Philippe Martin [email protected]

What does this PR do?

Add light mode for generic components in Dashboard (ProviderCard, GuideCard, LearningCenter)

Screenshot / video of UI

light-mode-dashboard

What issues does this PR fix or reference?

Fixes #6925

@feloy feloy requested review from benoitf and a team as code owners May 10, 2024 12:29
@feloy feloy requested review from cdrage and axel7083 and removed request for a team May 10, 2024 12:29
@feloy feloy marked this pull request as draft May 10, 2024 12:29
@feloy feloy requested review from deboer-tim and ekidneyrh and removed request for cdrage and axel7083 May 10, 2024 12:32
Copy link
Collaborator

@deboer-tim deboer-tim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wasn't sure I should review since it is also marked draft. LGTM but just missing the guide card hover color.

@feloy
Copy link
Contributor Author

feloy commented May 14, 2024

Wasn't sure I should review since it is also marked draft. LGTM but just missing the guide card hover color.

Yes, it is marked as draft as there are a few colors still to be defined, listed in #6925 (comment) and following (cc @ekidneyrh )

@feloy feloy marked this pull request as ready for review May 15, 2024 10:04
@feloy feloy requested a review from deboer-tim May 15, 2024 10:04
Signed-off-by: Philippe Martin <[email protected]>
@feloy
Copy link
Contributor Author

feloy commented May 16, 2024

ready for review

@feloy feloy merged commit d63be1f into containers:main May 16, 2024
8 checks passed
@podman-desktop-bot podman-desktop-bot added this to the 1.11.0 milestone May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Light mode for Dashboard
5 participants