Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: provider card UI on dashboard #7082

Merged
merged 2 commits into from May 13, 2024
Merged

Conversation

lstocchi
Copy link
Contributor

@lstocchi lstocchi commented May 3, 2024

What does this PR do?

This PR updates the provider cards UI to solve the misalignment issue #6973

Screenshot / video of UI

I've recorded a video where i cover almost all states.
Install podman, initialize and start, then delete the machine and initialize it + manual start. And i shrink/enlarge the window to show the different elements position.

The initialize step takes a lot, so skip it. I did not cut the video 馃槅
https://drive.google.com/file/d/1YYZz5QzkBsiIm5xeRcX_PBs_tbE-zjuA/view?usp=drive_link

What issues does this PR fix or reference?

it resolves #6973

How to test this PR?

  1. change state of your provider and see if it looks nice in the dashboard
  • Tests are covering the bug fix or the new feature

@lstocchi lstocchi requested review from benoitf and a team as code owners May 3, 2024 16:12
@lstocchi lstocchi requested review from dgolovin, axel7083 and ekidneyrh and removed request for a team May 3, 2024 16:12
@deboer-tim
Copy link
Collaborator

Scaling generally works better with this, but it causes overlap for OpenShift Local in some states, e.g.:
Screenshot 2024-05-03 at 1 01 41鈥疨M

@lstocchi
Copy link
Contributor Author

lstocchi commented May 3, 2024

Scaling generally works better with this, but it causes overlap for OpenShift Local in some states

Ah good catch. I think it would be the same on podman if i have an old version that requires an update. Gonna give this a look. Thanks!!

@lstocchi
Copy link
Contributor Author

lstocchi commented May 6, 2024

@ekidneyrh @deboer-tim My idea is to move the update button to prevent those kind of problems.
WDYT about these 2 options? Or do you have any other idea?

  1. Adding it just below the name
    image
    image

  2. Create a new row just above the link with the button centered
    image
    image

For the small screen maybe we can think about moving the title to the center

@axel7083
Copy link
Contributor

axel7083 commented May 6, 2024

@ekidneyrh @deboer-tim My idea is to move the update button to prevent those kind of problems. WDYT about these 2 options? Or do you have any other idea?

Could you include same screenshots with different podman-desktop size to see how the design is responding to different windows sizes ?

@lstocchi
Copy link
Contributor Author

lstocchi commented May 6, 2024

@ekidneyrh @deboer-tim My idea is to move the update button to prevent those kind of problems. WDYT about these 2 options? Or do you have any other idea?

Could you include same screenshots with different podman-desktop size to see how the design is responding to different windows sizes ?

Added. I didn't make any other modification. But, maybe, we should move the title to the center

@axel7083
Copy link
Contributor

axel7083 commented May 6, 2024

@ekidneyrh @deboer-tim My idea is to move the update button to prevent those kind of problems. WDYT about these 2 options? Or do you have any other idea?

Could you include same screenshots with different podman-desktop size to see how the design is responding to different windows sizes ?

Added. I didn't make any other modification. But, maybe, we should move the title to the center

Thanks!

@deboer-tim
Copy link
Collaborator

@ekidneyrh @deboer-tim My idea is to move the update button to prevent those kind of problems. WDYT about these 2 options? Or do you have any other idea?

Fundamentally I think the problem is that we have four columns (name, status description, install button, update button) which is just too many. Long term I'd prefer getting rid of one :) , but short term I agree that essentially making it wrap at the equivalent of 2-3 columns makes the most sense.

Out of these options I prefer 1 since it keeps the update button closer to the version, but maybe removing a bit of the top/bottom padding around the button to keep things a little closer together.

@lstocchi
Copy link
Contributor Author

lstocchi commented May 8, 2024

Updated by moving the update button to the left and reducing the padding/margin.
Full-width
image

Shrinked
image

@lstocchi lstocchi requested a review from deboer-tim May 8, 2024 09:16
Copy link
Collaborator

@deboer-tim deboer-tim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was still able to get the text to overlap - but I had to try really hard now. I think we're going to have diminishing returns until a bigger overhaul of what's on these tiles so let's merge and come back to this then. Well done Luca.

@lstocchi lstocchi merged commit ac5f58a into containers:main May 13, 2024
8 checks passed
@lstocchi lstocchi deleted the i6973_2 branch May 13, 2024 07:12
@podman-desktop-bot podman-desktop-bot added this to the 1.11.0 milestone May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dashboard podman row is misaligned to the right
5 participants