fix(extensions): make sure periodical full ui reload doesn't happen #6693
+244
−106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: GLEF1X <[email protected]>
benoitf
reviewed
Apr 9, 2024
| extensionApi.env.createTelemetryLogger().logError(err.toString()); | ||
| } | ||
| }); | ||
| void monitorDaemon(extensionContext); |
There was a problem hiding this comment.
hello, here it looks you're bypassing the linter and do not catch error on promises, etc.
There was a problem hiding this comment.
monitorDaemon doesn't return a promise
| extensionApi.env.createTelemetryLogger().logError(err.toString()); | ||
| function monitorDaemon(extensionContext: extensionApi.ExtensionContext): void { | ||
| const loop = (): NodeJS.Timeout => | ||
| // eslint-disable-next-line @typescript-eslint/no-misused-promises |
There was a problem hiding this comment.
we should not ignore the misused-promises in the project
| // Start monitoring by calling passed in constructor parameters function until stopLoopPredicate returns false | ||
| start(): void { | ||
| const loop = (): NodeJS.Timeout => | ||
| // eslint-disable-next-line @typescript-eslint/no-misused-promises |
There was a problem hiding this comment.
Should be reused among extensions, because it is common pattern throughout:
- run callback on constant intervals,
- do not fail on error in callback just report it or allow to configure error handling caback,
- provide predicate function for exit from monitoring loop
Monitoring loop can be implemented as (see timers/promises example
import { setInterval } from 'node:timers/promises';
for await (const _interval of setInterval(interval)) {
try {
await callback(extensionContext);
} catch (error) {
errorhandler?(error)
}
if (stopLoop)
break;
}There was a problem hiding this comment.
or use npm package like 'set-interval-async' that would handle some other usecases
// Dynamic strategy.
import { setIntervalAsync, clearIntervalAsync } from 'set-interval-async/dynamic';
const timer = setIntervalAsync(async () => {
// ...
if (shouldStop) {
await clearIntervalAsync(timer);
}
try {
await callback()
} catch(err) {
handleError(err);
}
}, interval);
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: GLEF1X [email protected]
What does this PR do?
Attempts to resolve problems stated in #6663(full UI reload because the nodejs stack is overflowing)
Screenshot / video of UI
What issues does this PR fix or reference?
#6663
How to test this PR?