Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(api): creating api package #6606

Merged
merged 3 commits into from May 14, 2024

Conversation

axel7083
Copy link
Contributor

@axel7083 axel7083 commented Apr 3, 2024

What does this PR do?

Moving directly all packages/main/src/plugin/api in one PR would make it hard to review due to the numbers of import that would be impacted. This first PR create the packages/api folder, and set the required configuration in the packages that will use the /@api/*.

⚠️ Packages that will not use the api are: packages/ui and packages/extension-api.

Screenshot / video of UI

What issues does this PR fix or reference?

Related to #6300

How to test this PR?

  • Tests are covering the bug fix or the new feature

@axel7083 axel7083 requested review from benoitf and a team as code owners April 3, 2024 09:07
@axel7083 axel7083 requested review from dgolovin and jeffmaury and removed request for a team April 3, 2024 09:07
@benoitf
Copy link
Collaborator

benoitf commented Apr 3, 2024

hi @axel7083 , AFAIK technical debts issues are for post 1.10 release

@axel7083
Copy link
Contributor Author

axel7083 commented Apr 3, 2024

hi @axel7083 , AFAIK technical debts issues are for post 1.10 release

Okey, I was not aware as I had the issue assigned for this sprint

@axel7083 axel7083 marked this pull request as draft April 3, 2024 11:07
@benoitf
Copy link
Collaborator

benoitf commented Apr 3, 2024

@axel7083 I think we moved it from the previous sprint to the next one but it should be moved to the next one and finally we should be able to handle lot of this kind of issues 🎉

@axel7083 axel7083 marked this pull request as ready for review April 24, 2024 15:20
@benoitf
Copy link
Collaborator

benoitf commented Apr 25, 2024

need to have 1.10 promoted release before being able to merge (to have easy backports to the 1.10 branch)

@benoitf benoitf marked this pull request as draft April 25, 2024 14:56
@axel7083 axel7083 marked this pull request as ready for review April 29, 2024 16:01
packages/api/tsconfig.json Outdated Show resolved Hide resolved
@axel7083 axel7083 force-pushed the chore/creating-api-package branch from f872913 to 4d008de Compare May 13, 2024 07:22
@axel7083 axel7083 linked an issue May 13, 2024 that may be closed by this pull request
@axel7083 axel7083 merged commit ba70ba9 into containers:main May 14, 2024
8 checks passed
@podman-desktop-bot podman-desktop-bot added this to the 1.11.0 milestone May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create api package for sharing code between main and renderer
3 participants