chore: dropdown component #6241
Draft
+177
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deboer-tim
requested review from
jeffmaury and
cdrage
and removed request for
a team
benoitf
reviewed
Mar 3, 2024
Creates a new Dropdown component that is just a styled select control, so that we don't have slight variations and styling in several places, and one less thing to fix for light-mode. Styling uses the same color pattern as an Input for consistency. I used the new component in three places to start so that there's something to test: deploying a pod to Kube, creating a pod from containers, and enum items in preferences. There are 11 other instances of <select> that will need to be switched in future PRs. Signed-off-by: Tim deBoer <[email protected]>
|
Rebased, renamed to Dropdown, updated to current Input styling, updated PR description, and added proposed dropdown color variables for UX review. |
|
I'm using Fedora Linux and the dropdown options are the same colour as the bg making it illegible. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Creates a new Dropdown component that is just a styled select control, so that we don't have this styling/slight variations in several places, and one less thing to fix for light-mode. Styling uses the same variable naming pattern as an Input.
I used the new component in three places to start so that there's something to test: deploying a pod to Kube, creating a pod from containers, and enum items in preferences. There are 11 other instances of
<select>that will need to be switched in future PRs.Screenshot / video of UI
Screen.Recording.2024-03-20.at.8.33.17.AM.mov
What issues does this PR fix or reference?
First step of #6199.
How to test this PR?
Unit test included; go to the places listed in the UI to test styling/behaviour.