Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Light mode for NavPage & FormPage #6889

Closed
deboer-tim opened this issue Apr 23, 2024 · 2 comments · Fixed by #7149
Closed

Light mode for NavPage & FormPage #6889

deboer-tim opened this issue Apr 23, 2024 · 2 comments · Fixed by #7149
Assignees
@feloy
Labels
area/dashboard 📊 Concern the dashboard from Container Desktop kind/enhancement ✨ Issue for requesting an improvement

Comments

@deboer-tim
Copy link
Collaborator

Is your enhancement related to a problem? Please describe

We need to support light mode on these two pages, since they're used extensively.

Describe the solution you'd like

Define missing bg/tile/divider colors in the light mode palette and use them in these pages (bg color likely one page up).

Describe alternatives you've considered

No response

Additional context

No response
@deboer-tim deboer-tim added the kind/enhancement ✨ Issue for requesting an improvement label Apr 23, 2024
@deboer-tim deboer-tim mentioned this issue Apr 23, 2024
Open
23 tasks
@benoitf benoitf added area/dashboard 📊 Concern the dashboard from Container Desktop and removed status/need-triage labels Apr 24, 2024
@feloy
Copy link
Contributor

feloy commented May 7, 2024

@deboer-tim what do you mean by bg color likely one page up ?

@deboer-tim
Copy link
Collaborator Author

@deboer-tim what do you mean by bg color likely one page up ?

I think the background color comes from App.svelte:102/3, not the pages themselves.

@feloy feloy mentioned this issue May 10, 2024
Merged
@deboer-tim deboer-tim mentioned this issue May 14, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@feloy feloy

Labels
area/dashboard 📊 Concern the dashboard from Container Desktop kind/enhancement ✨ Issue for requesting an improvement
Projects
Podman Desktop Planning
Status: ✔️ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Light mode for NavPage & FormPage feloy/podman-desktop
4 participants
@benoitf @feloy @deboer-tim @podman-desktop-bot