Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Light Mode Support #4914

Open
26 of 45 tasks
deboer-tim opened this issue Nov 21, 2023 · 3 comments
Open
26 of 45 tasks

Light Mode Support #4914

deboer-tim opened this issue Nov 21, 2023 · 3 comments
Assignees
@deboer-tim
Labels
kind/epic⚡ Issue describing an epic

Comments

@deboer-tim
Copy link
Collaborator

deboer-tim commented Nov 21, 2023 •
edited

Epic domain

We have had requests for light mode for some time for obvious reasons: astigmatism, system default, or just users who prefer it better. Opening this epic to track the overall work.

Additional context

Initial request: #576 (maybe can be the 'final' issue we resolve to expose the mode).

Technical implementation:

Sprint 256:

Sprint 257:

Sprint 258:

Planned for Sprint 259:

Remaining items:
@deboer-tim deboer-tim changed the title Light mode Support Light Mode Support Nov 21, 2023
@benoitf
Copy link
Collaborator

benoitf commented Nov 21, 2023

@deboer-tim : maybe we change #576 to be the epic as most of the people are following this issue ?

@deboer-tim
Copy link
Collaborator Author

I almost did that, then thought most of those users just want to know when it is 'planned' and 'available' and don't care as much about the overall status or steps to get there. If you think it's better we can move to #576 and close this one.

@benoitf
Copy link
Collaborator

benoitf commented Nov 21, 2023 •
edited

no I'm fine, you're right

@nichjones1 nichjones1 added kind/epic⚡ Issue describing an epic and removed status/need-triage labels Nov 21, 2023
@mairin mairin mentioned this issue Feb 6, 2024
Closed
deboer-tim added a commit that referenced this issue May 10, 2024
@deboer-tim
chore: checkbox light mode
df43acb 
Add entries to the color registry for checkbox, with support for
light mode. Light mode colors are the same for now since I couldn't
find a precedent, except for unchecked.

Took this opportunity to add focus (hover) states since they were
missing and didn't match other UI elements. For unchecked the outline
becomes purple, for all other states it's one step lighter for dark
mode and darker for light mode.

Part of #4914.

Signed-off-by: Tim deBoer <[email protected]>
@deboer-tim deboer-tim mentioned this issue May 10, 2024
Merged
1 task
deboer-tim added a commit that referenced this issue May 14, 2024
@deboer-tim
chore: checkbox light mode
8f16848 
Add entries to the color registry for checkbox, with support for
light mode. Light mode colors are the same for now since I couldn't
find a precedent, except for unchecked.

Took this opportunity to add focus (hover) states since they were
missing and didn't match other UI elements. For unchecked the outline
becomes purple, for all other states it's one step lighter for dark
mode and darker for light mode.

Part of #4914.

Signed-off-by: Tim deBoer <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@deboer-tim deboer-tim

Labels
kind/epic⚡ Issue describing an epic
Projects
Podman Desktop Planning
Status: 📋 Backlog
Milestone
No milestone
Development

No branches or pull requests
4 participants
@benoitf @deboer-tim @podman-desktop-bot @nichjones1