fix: fix test

Signed-off-by: lstocchi <[email protected]>
containers · May 13, 2024 · 4b244e0 · 4b244e0
1 parent 8d871e9
commit 4b244e0
Show file tree

Hide file tree

Showing 14 changed files with 99 additions and 41 deletions.
diff --git a/packages/renderer/src/lib/deployments/DeploymentColumnConditions.svelte b/packages/renderer/src/lib/deployments/DeploymentColumnConditions.svelte
@@ -34,9 +34,11 @@ function getConditionColour(type: string): string {
  </div>
  </svelte:fragment>
  <svelte:fragment slot="tip">
- <div class="inline-block py-2 px-4 rounded-md bg-charcoal-800 text-xs text-white" aria-label="tooltip">
- {condition.message}
- </div>
+ {#if condition.message}
+ <div class="inline-block py-2 px-4 rounded-md bg-charcoal-800 text-xs text-white" aria-label="tooltip">
+ {condition.message}
+ </div>
+ {/if}
  </svelte:fragment>
  </Tooltip>
  {/each}

diff --git a/packages/renderer/src/lib/donut/Donut.svelte b/packages/renderer/src/lib/donut/Donut.svelte
@@ -48,8 +48,10 @@ $: tooltip = percent ? percent.toFixed(0) + '% ' + title + ' usage' : '';
  </svg>
  </svelte:fragment>
  <svelte:fragment slot="tip">
- <div class="inline-block py-2 px-4 rounded-md bg-charcoal-800 text-xs text-white" aria-label="tooltip">
- {tooltip}
- </div>
+ {#if tooltip}
+ <div class="inline-block py-2 px-4 rounded-md bg-charcoal-800 text-xs text-white" aria-label="tooltip">
+ {tooltip}
+ </div>
+ {/if}
  </svelte:fragment>
 </Tooltip>
diff --git a/packages/renderer/src/lib/preferences/item-formats/FloatNumberItem.svelte b/packages/renderer/src/lib/preferences/item-formats/FloatNumberItem.svelte
@@ -83,9 +83,11 @@ function assertNumericValueIsValid(value: number): boolean {
  aria-label="{record.description}" />
  </svelte:fragment>
  <svelte:fragment slot="tip">
- <div class="inline-block py-2 px-4 rounded-md bg-charcoal-800 text-xs text-white" aria-label="tooltip">
- {numberInputErrorMessage}
- </div>
+ {#if numberInputErrorMessage}
+ <div class="inline-block py-2 px-4 rounded-md bg-charcoal-800 text-xs text-white" aria-label="tooltip">
+ {numberInputErrorMessage}
+ </div>
+ {/if}
  </svelte:fragment>
  </Tooltip>
 </div>
diff --git a/packages/renderer/src/lib/preferences/item-formats/NumberItem.svelte b/packages/renderer/src/lib/preferences/item-formats/NumberItem.svelte
@@ -50,8 +50,10 @@ $: if (error) {
  </NumberInput>
  </svelte:fragment>
  <svelte:fragment slot="tip">
- <div class="inline-block py-2 px-4 rounded-md bg-charcoal-800 text-xs text-white" aria-label="tooltip">
- {error}
- </div>
+ {#if error}
+ <div class="inline-block py-2 px-4 rounded-md bg-charcoal-800 text-xs text-white" aria-label="tooltip">
+ {error}
+ </div>
+ {/if}
  </svelte:fragment>
 </Tooltip>
diff --git a/packages/renderer/src/lib/ui/ErrorMessage.svelte b/packages/renderer/src/lib/ui/ErrorMessage.svelte
@@ -0,0 +1,32 @@
+<script lang="ts">
+import { faExclamationCircle } from '@fortawesome/free-solid-svg-icons';
+import { Tooltip } from '@podman-desktop/ui-svelte';
+import Fa from 'svelte-fa';
+
+export let error: string;
+export let icon = false;
+</script>
+
+{#if icon}
+ {#if error !== undefined && error !== ''}
+ <Tooltip top>
+ <svelte:fragment slot="item">
+ <Fa size="1.1x" class="cursor-pointer text-red-500 {$$props.class}" icon="{faExclamationCircle}" />
+ </svelte:fragment>
+ <svelte:fragment slot="tip">
+ {#if error}
+ <div class="inline-block py-2 px-4 rounded-md bg-charcoal-800 text-xs text-white" aria-label="tooltip">
+ {error}
+ </div>
+ {/if}
+ </svelte:fragment>
+ </Tooltip>
+ {/if}
+{:else}
+ <div
+ class="text-red-500 p-1 flex flex-row items-center {$$props.class}"
+ class:opacity-0="{error === undefined || error === ''}">
+ <Fa size="1.1x" class="cursor-pointer text-red-500" icon="{faExclamationCircle}" />
+ <div role="alert" aria-label="Error Message Content" class="ml-2">{error}</div>
+ </div>
+{/if}
diff --git a/packages/renderer/src/lib/ui/KubernetesCurrentContextConnectionBadge.svelte b/packages/renderer/src/lib/ui/KubernetesCurrentContextConnectionBadge.svelte
@@ -28,9 +28,11 @@ $: text = getText($kubernetesCurrentContextState);
  {text}
  </svelte:fragment>
  <svelte:fragment slot="tip">
- <div class="inline-block py-2 px-4 rounded-md bg-charcoal-800 text-xs text-white" aria-label="tooltip">
- {$kubernetesCurrentContextState.error}
- </div>
+ {#if $kubernetesCurrentContextState.error}
+ <div class="inline-block py-2 px-4 rounded-md bg-charcoal-800 text-xs text-white" aria-label="tooltip">
+ {$kubernetesCurrentContextState.error}
+ </div>
+ {/if}
  </svelte:fragment>
  </Tooltip>
  {:else}

diff --git a/packages/renderer/src/lib/ui/LoadingIconButton.svelte b/packages/renderer/src/lib/ui/LoadingIconButton.svelte
@@ -64,8 +64,10 @@ $: style = disable
  </button>
  </svelte:fragment>
  <svelte:fragment slot="tip">
- <div class="inline-block py-2 px-4 rounded-md bg-charcoal-800 text-xs text-white" aria-label="tooltip">
- {tooltip}
- </div>
+ {#if tooltip}
+ <div class="inline-block py-2 px-4 rounded-md bg-charcoal-800 text-xs text-white" aria-label="tooltip">
+ {tooltip}
+ </div>
+ {/if}
  </svelte:fragment>
 </Tooltip>
diff --git a/packages/renderer/src/lib/ui/NavItem.svelte b/packages/renderer/src/lib/ui/NavItem.svelte
@@ -54,9 +54,11 @@ onDestroy(() => {
  <slot />
  </svelte:fragment>
  <svelte:fragment slot="tip">
- <div class="inline-block py-2 px-4 rounded-md bg-charcoal-800 text-xs text-white" aria-label="tooltip">
- {tooltip}
- </div>
+ {#if tooltip}
+ <div class="inline-block py-2 px-4 rounded-md bg-charcoal-800 text-xs text-white" aria-label="tooltip">
+ {tooltip}
+ </div>
+ {/if}
  </svelte:fragment>
  </Tooltip>
  </div>

diff --git a/packages/renderer/src/lib/ui/NavSection.svelte b/packages/renderer/src/lib/ui/NavSection.svelte
@@ -48,9 +48,11 @@ onMount(() => {
  </div>
  </svelte:fragment>
  <svelte:fragment slot="tip">
- <div class="inline-block py-2 px-4 rounded-md bg-charcoal-800 text-xs text-white" aria-label="tooltip">
- {tooltip}
- </div>
+ {#if tooltip}
+ <div class="inline-block py-2 px-4 rounded-md bg-charcoal-800 text-xs text-white" aria-label="tooltip">
+ {tooltip}
+ </div>
+ {/if}
  </svelte:fragment>
  </Tooltip>
  </button>

diff --git a/packages/renderer/src/lib/ui/ProviderInfo.svelte b/packages/renderer/src/lib/ui/ProviderInfo.svelte
@@ -39,9 +39,11 @@ function getProviderColour(providerName: string): string {
  {provider}
  </svelte:fragment>
  <svelte:fragment slot="tip">
- <div class="inline-block py-2 px-4 rounded-md bg-charcoal-800 text-xs text-white" aria-label="tooltip">
- {context}
- </div>
+ {#if context}
+ <div class="inline-block py-2 px-4 rounded-md bg-charcoal-800 text-xs text-white" aria-label="tooltip">
+ {context}
+ </div>
+ {/if}
  </svelte:fragment></Tooltip>
  {:else}
  {provider}

diff --git a/packages/renderer/src/lib/ui/StatusDot.svelte b/packages/renderer/src/lib/ui/StatusDot.svelte
@@ -39,8 +39,10 @@ let dotClass = getStatusColor(status);
  </svelte:fragment>
 
  <svelte:fragment slot="tip">
- <div class="inline-block py-2 px-4 rounded-md bg-charcoal-800 text-xs text-white" aria-label="tooltip">
- {tooltip}
- </div>
+ {#if tooltip}
+ <div class="inline-block py-2 px-4 rounded-md bg-charcoal-800 text-xs text-white" aria-label="tooltip">
+ {tooltip}
+ </div>
+ {/if}
  </svelte:fragment>
 </Tooltip>
diff --git a/packages/renderer/src/lib/ui/WarningMessage.svelte b/packages/renderer/src/lib/ui/WarningMessage.svelte
@@ -14,9 +14,11 @@ export let icon = false;
  <Fa size="1.125x" class="cursor-pointer text-amber-500" icon="{faTriangleExclamation}" />
  </svelte:fragment>
  <svelte:fragment slot="tip">
- <div class="inline-block py-2 px-4 rounded-md bg-charcoal-800 text-xs text-white" aria-label="tooltip">
- {error}
- </div>
+ {#if error}
+ <div class="inline-block py-2 px-4 rounded-md bg-charcoal-800 text-xs text-white" aria-label="tooltip">
+ {error}
+ </div>
+ {/if}
  </svelte:fragment>
  </Tooltip>
  {/if}

diff --git a/packages/renderer/src/lib/welcome/WelcomePage.svelte b/packages/renderer/src/lib/welcome/WelcomePage.svelte
@@ -133,11 +133,13 @@ function startOnboardingQueue() {
  {onboarding.displayName}
  </svelte:fragment>
  <svelte:fragment slot="tip">
- <div
- class="inline-block py-2 px-4 rounded-md bg-charcoal-800 text-xs text-white"
- aria-label="tooltip">
- {onboarding.description}
- </div>
+ {#if onboarding.description}
+ <div
+ class="inline-block py-2 px-4 rounded-md bg-charcoal-800 text-xs text-white"
+ aria-label="tooltip">
+ {onboarding.description}
+ </div>
+ {/if}
  </svelte:fragment>
  </Tooltip>
  </div>

diff --git a/packages/ui/src/lib/alert/ErrorMessage.svelte b/packages/ui/src/lib/alert/ErrorMessage.svelte
@@ -15,9 +15,11 @@ export let icon = false;
  <Fa size="1.1x" class="cursor-pointer text-red-500 {$$props.class}" icon="{faExclamationCircle}" />
  </svelte:fragment>
  <svelte:fragment slot="tip">
- <div class="inline-block py-2 px-4 rounded-md bg-charcoal-800 text-xs text-white" aria-label="tooltip">
- {error}
- </div>
+ {#if error}
+ <div class="inline-block py-2 px-4 rounded-md bg-charcoal-800 text-xs text-white" aria-label="tooltip">
+ {error}
+ </div>
+ {/if}
  </svelte:fragment>
  </Tooltip>
  {/if}