Add disable-extra-hosts flag #692
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds a new flag to disable extra hosts when running podman-compose up. This helps use podman-compose 0.1.x with podman > v4.1. Fixes issue containers/podman#15373 Signed-off-by: Arjun Nemani <[email protected]>
|
@muayyad-alsadi Please let me know if you can merge this in and also maybe release a 0.1.12 version with this change. that would allow us to use this script without maintaining a copy. Let me know if there are any improvements or feedback on the code. :) |
|
bump |
1 similar comment
|
bump |
|
I think the current solution cannot be accepted. It is effectively removing extra_hosts config from compose yml, so why not just remove it from a file instead of introducing the flag.
Proper solution would be to add extra hosts to the pod level. This would be an incompatibility with docker compose, but unfortunately we can't solve it another way. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds a new flag to disable extra hosts when running podman-compose up. This helps use podman-compose 0.1.x with podman > v4.1.
Fixes issue containers/podman#15373
Usage:
podman-compose -f file.yaml up -d --disable-extra-hosts