Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a CONTRIBUTING.md #381

Merged
merged 1 commit into from
Oct 25, 2024
Merged

Conversation

cgwalters
Copy link
Contributor

Motivated by improving our project standards.

Copy link
Member

@giuseppe giuseppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
@giuseppe
Copy link
Member

used this PR as a base for containers/crun#1590

Motivated by improving our project standards.

Signed-off-by: Colin Walters <[email protected]>
@cgwalters cgwalters merged commit 0cb1f05 into containers:main Oct 25, 2024
11 of 15 checks passed
@eriksjolund
Copy link
Collaborator

Sidenote regarding the line

- If your commit fixes an issue, the commit message should end with `Closes: #<number>`.

No previous commits fulfil the requirement

$ git clone -q https://github.com/containers/composefs.git
$ git -C composefs log | grep 'Closes: #' | wc -l
       0

(I'm fine with the change. I just wanted to mention this fact)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants