Skip to content

Conversation

@lsm5
Copy link
Member

@lsm5 lsm5 commented May 21, 2025

What type of PR is this?

/kind documentation

What this PR does / why we need it:

Adds openssf passing badge to satisfy CNCF requirement

How to verify it

See badge on README.md at https://github.com/lsm5/buildah/tree/openssf-passing

Which issue(s) this PR fixes:

None

Special notes for your reviewer:

Feel free to check out https://www.bestpractices.dev/en/projects/10579 before LGTM.

Does this PR introduce a user-facing change?

None

@lsm5 lsm5 force-pushed the openssf-passing branch from 9d04aaa to eee1f21 Compare May 21, 2025 14:50
@packit-as-a-service
Copy link

Ephemeral COPR build failed. @containers/packit-build please check.

@lsm5
Copy link
Member Author

lsm5 commented May 21, 2025

@containers/buildah-maintainers PTAL

I prefer we not merge this until lgtm'd by @mtrmac at least.

@lsm5
Copy link
Member Author

lsm5 commented May 21, 2025

The security evaluation skips stuff inside vendor/ as in podman and skopeo

@mtrmac
Copy link
Contributor

mtrmac commented May 21, 2025

Crypto uses (outside vendor) LGTM. I didn’t re-check all of the badge requirements.

I have filed #6182 to track a cleanup. That feature is undocumented and, AFAICT, entirely unsupported for use by external users, so I don’t think it has to be listed in the badge evaluation — but I want to have a written record for why it is out of scope.

@lsm5
Copy link
Member Author

lsm5 commented May 22, 2025

@containers/buildah-maintainers PTAL

@lsm5
Copy link
Member Author

lsm5 commented May 27, 2025

@containers/buildah-maintainers mergeme

Copy link
Member

@giuseppe giuseppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 28, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: giuseppe, lsm5

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rhatdan
Copy link
Member

rhatdan commented May 28, 2025

/lgtm

@openshift-ci openshift-ci bot added the lgtm label May 28, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit 199468a into containers:main May 28, 2025
29 checks passed
@stale-locking-app stale-locking-app bot locked as resolved and limited conversation to collaborators Aug 27, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants