add: add a new --timestamp flag #6178
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
the
kind/feature
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nalind The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Ephemeral COPR build failed. @containers/packit-build please check. |
nalind
force-pushed
the
add-timestamp
branch
2 times, most recently
from
7904b43 to
2adc23a
Compare
Add some helper functions for parsing the information from dir: and oci: locations that we'd just have to do over and over with minor variations, to try to save some time and a refactor down the road. Signed-off-by: Nalin Dahyabhai <[email protected]>
Add a --timestamp flag to the "add" and "copy" CLIs, along with a corresponding field in AddAndCopyOptions. When a timestamp is set, we'll force the timestamp on data copied in to be the specified value while reading it, so that the content will have the specified datestamp in the rootfs and when the image is committed. Signed-off-by: Nalin Dahyabhai <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
Add a "--timestamp" flag to the "add" and "copy" CLIs, along with a corresponding field in
AddAndCopyOptions.When a timestamp is set, we'll force the timestamp on data copied in to be the specified value while reading it, so that the content will have the specified datestamp in the rootfs and when the image is committed.
How to verify it
Updated unit test!
New integration test!
Which issue(s) this PR fixes:
None
Special notes for your reviewer:
Does this PR introduce a user-facing change?