[CI:DOCS] Add CNCF roadmap, touchup other CNCF files #6124
Conversation
TomSweeneyRedHat
force-pushed
the
dev/tsweeney/cncfstart
branch
from
f2de84b to
b3c617b
Compare
|
LGTM |
|
The update to MAINTAINERS.md isn't currently reflected in OWNERS. |
TomSweeneyRedHat
force-pushed
the
dev/tsweeney/cncfstart
branch
from
b3c617b to
3a9b96e
Compare
TomSweeneyRedHat
force-pushed
the
dev/tsweeney/cncfstart
branch
from
3a9b96e to
fbf2d20
Compare
|
Ephemeral COPR build failed. @containers/packit-build please check. |
GOVERNANCE.md
Outdated
|
|
||
| The definitive source of truth for maintainers of this repository is the local [MAINTAINERS.md](./MAINTAINERS.md) file. The [MAINTAINERS.md](https://github.com/containers/podman/blob/main/MAINTAINERS.md) file in the main Podman repository is used for project-spanning roles, including Core Maintainer and Community Manager. Some repositories in the project will also have a local [OWNERS](./OWNERS) file, which the CI system uses to map users to roles. Any changes to the [OWNERS](./OWNERS) file must make a corresponding change to the [MAINTAINERS.md](./MAINTAINERS.md) file to ensure that the file remains up to date. Most changes to [MAINTAINERS.md](./MAINTAINERS.md) will require a change to the repository’s [OWNERS](.OWNERS) file (e.g., adding a Reviewer), but some will not (e.g., promoting a Maintainer to a Core Maintainer, which comes with no additional CI-related privileges). | ||
|
|
||
| Any Core Maintainers listed in Podman’s [MAINTAINERS.md](https://github.com/containers/podman/blob/main/MAINTAINERS.md) file should also be added to the list of “approvers” in the local [OWNERS](./OWNERS) file and to the list of “Maintainers” in the local [MAINTAINERS.md](./MAINTAINERS.md) file. |
There was a problem hiding this comment.
I don't think we need to add Core Maintainers as Maintainers. Either list them as Core Maintainers or not at all, and say the definitive list exists in the Podman repo.
There was a problem hiding this comment.
I'll try an new wording. We need to add them to the OWNERS file so the CI will be happy with them. I'd like to have a corresponding entry in the Maintainers file, but do think they should be listed as a Core-Maintainer. I'll spell that out a bit more. FWIW, that's what the file has now under the list of "Maintainers", both Maintainers and Core Maintainers in that list.
|
Making @flouthoc a maintainer LGTM |
TomSweeneyRedHat
force-pushed
the
dev/tsweeney/cncfstart
branch
from
fbf2d20 to
2a72c27
Compare
TomSweeneyRedHat
force-pushed
the
dev/tsweeney/cncfstart
branch
from
2a72c27 to
4b9e2bd
Compare
|
Can you remove the unnecessary merge commit? PRs should be rebased instead of adding the extra merge main into branch commit. If the question is about the CI then it just broken since the go compiler is to old. IMO we should just drop these tasks like we did in podman, they add nothing but noise here. |
Added a ROADMAP.md file per CNCF requirements. Updated the GOVERNANCE.md file to point to and use the local MAINTAINERS.md file instead of the one in Podman. Also added links to the OWNERS file. Updated the MAINTAINERS.md file to bump Aditya Rajan to a Maintainer from a reviewer. Having him as a reviewer was a cut/paste error that was not caught when the file was first generated from the Podman file. Signed-off-by: tomsweeneyredhat <[email protected]>
TomSweeneyRedHat
force-pushed
the
dev/tsweeney/cncfstart
branch
from
46e4fae to
7fbca08
Compare
|
I'm not sure how I managed the extra commit, but thanks for the heads up @Luap99 , I squished it. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lsm5, Luap99, TomSweeneyRedHat The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Added a ROADMAP.md file per CNCF requirements.
Updated the GOVERNANCE.md file to point to and use the local MAINTAINERS.md file instead of the one in Podman. Also added links to the OWNERS file.
Updated the MAINTAINERS.md file to bump Aditya Rajan to a Maintainer from a reviewer. Having him as a reviewer was a cut/paste error that was not caught when the file was first generated from the Podman file.
What type of PR is this?
What this PR does / why we need it:
How to verify it
Which issue(s) this PR fixes:
Special notes for your reviewer:
Does this PR introduce a user-facing change?