Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix docs: 'ifnewer' vs 'newer' in buildah pull --policy option. #5524

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

krrg
Copy link

@krrg krrg commented May 10, 2024

What type of PR is this?

/kind documentation

What this PR does / why we need it:

The docs incorrectly state the parameter as being 'newer', but the actual name of this parameter is 'ifnewer', at least as of the latest version of buildah (1.35.3).

How to verify it

buildah pull --policy=ifnewer <image> (succeeds)
buildah pull --policy=newer <image> (fails)

None

The docs incorrectly state the parameter as being 'newer',
but the actual name of this parameter is 'ifnewer'.

Signed-off-by: Ken Reese <[email protected]>
@openshift-ci openshift-ci bot added the kind/documentation Categorizes issue or PR as related to documentation. label May 10, 2024
Copy link
Contributor

openshift-ci bot commented May 10, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: krrg
Once this PR has been reviewed and has the lgtm label, please assign flouthoc for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

Ephemeral COPR build failed. @containers/packit-build please check.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/documentation Categorizes issue or PR as related to documentation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant