Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nuke the new nixery image #5479

Closed
wants to merge 1 commit into from
Closed

Conversation

edsantiago
Copy link
Collaborator

Registry has been down for a day. This is blocking all CI.

Switch to $SAFEIMAGE, our quay.io testimage.

Signed-off-by: Ed Santiago [email protected]

None

Registry has been down for a day. This is blocking all CI.

Switch to $SAFEIMAGE, our quay.io testimage.

Signed-off-by: Ed Santiago <[email protected]>
Copy link

Ephemeral COPR build failed. @containers/packit-build please check.

Copy link
Collaborator

@flouthoc flouthoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

openshift-ci bot commented Apr 18, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: edsantiago, flouthoc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@edsantiago
Copy link
Collaborator Author

@nalind PTAL. I have a bad feeling that the reason this PR is passing is because the test is not actually a test. That is, that there is something magical about the nixery image that causes this test to fail, but there is no actual testing anywhere in the test to verify that this magical attribute exists in the image being tested.

nixery is back up, and I've pulled the image, and I'll try to figure out what is so special about it, but your help would be most appreciated.

@edsantiago
Copy link
Collaborator Author

nixery is back up, so here are my findings:

  1. The magic attribute that we're looking for seems to be:
$ podman inspect nixery.dev/shell:latest --format '{{.History}}'
[]

(i.e., empty "History" field)

  1. buildah 1.34.1 does not manifest the bug, but I checked out 8098bf2 , built it, and the new bud-implicit-no-history test fails as follows:
...
[2/2] COMMIT
Error: committing container for step {...}: \
    copying layers and metadata for container "SHA": \
    initializing source containers-storage:6164d56ff2d5-working-container: \
    internal error: history lists 2 non-empty layers, but we have 13 layers on disk

What I would like to do now is craft a custom image with this same History attribute. Preferably something we can craft inline in the test itself, but at least something we can store on quay. @nalind, I could figure that out eventually, but if you have any advice on how to do that I would hugely appreciate it.

@nalind
Copy link
Member

nalind commented Apr 18, 2024

There's a patch in #5473 that crafts a suitable image to get around this.

@edsantiago edsantiago closed this Apr 22, 2024
@edsantiago edsantiago deleted the nuke-nixery branch April 22, 2024 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants