Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add: add support for git sources #5438

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

add: add support for git sources #5438

wants to merge 2 commits into from
+119 −26

Conversation

danishprakash
Copy link
Contributor

What type of PR is this?

/kind feature

What this PR does / why we need it:

adds support for git sources with the ADD directive

How to verify it

Which issue(s) this PR fixes:

Fixes #4974

Special notes for your reviewer:

Does this PR introduce a user-facing change?

adds support for git sources with the ADD directive

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Mar 27, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: danishprakash
Once this PR has been reviewed and has the lgtm label, please assign lsm5 for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@danishprakash danishprakash force-pushed the add-git-ref branch 4 times, most recently from 3a3abfc to 3d0f34a Compare April 5, 2024 07:15
@danishprakash danishprakash force-pushed the add-git-ref branch 2 times, most recently from aba9551 to 3a83d68 Compare April 22, 2024 14:24
@packit-as-a-service Packit-as-a-Service
Copy link

Ephemeral COPR build failed. @containers/packit-build please check.

@danishprakash danishprakash force-pushed the add-git-ref branch 3 times, most recently from da7f372 to 92ed66a Compare April 23, 2024 14:40
@danishprakash danishprakash marked this pull request as ready for review April 23, 2024 14:41
@TomSweeneyRedHat
Copy link
Member

Quick fly by review looks OK to me, but you have test issues and a rebase is needed.

@danishprakash
Copy link
Contributor Author

Quick fly by review looks OK to me, but you have test issues and a rebase is needed.

You meant packit issues? Because tests seems to be fine afaict

rhatdan
rhatdan reviewed May 13, 2024
View reviewed changes
add.go Outdated Show resolved Hide resolved
@rhatdan
Copy link
Member

rhatdan commented May 13, 2024

LGTM other then remove the MustCompile.

@flouthoc @nalind @giuseppe PTAL

eriksjolund
eriksjolund reviewed May 14, 2024
View reviewed changes
add.go Outdated Show resolved Hide resolved
@rhatdan
Copy link
Member

rhatdan commented May 21, 2024

LGTM
@flouthoc @giuseppe @nalind @mheon PTAL

@TomSweeneyRedHat
Copy link
Member

Changes LGTM

I did a rebase which was required, and now the DCO (signing) test is not passing. Did you forget to sign a recent commit @danishprakash ?

@danishprakash
Copy link
Contributor Author

I switched git emails recently, that was the issue, fixed now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@giuseppe giuseppe giuseppe left review comments

@eriksjolund eriksjolund eriksjolund left review comments

@rhatdan rhatdan rhatdan left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support for ADD <git ref> in Containerfile
5 participants
@danishprakash @TomSweeneyRedHat @rhatdan @giuseppe @eriksjolund